- Notifications
You must be signed in to change notification settings - Fork928
fix: remove unimplemented account links#1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedMay 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1411 +/- ##==========================================- Coverage 67.29% 67.23% -0.06%========================================== Files 288 286 -2 Lines 19109 19097 -12 Branches 241 241 ==========================================- Hits 12859 12840 -19- Misses 4936 4938 +2- Partials 1314 1319 +5
Continue to review full report at Codecov.
|
It appears unclear as of now when/if these will be implemented so Iopted to remove them (as opposed to commenting them out) to avoid havingthem rot (they are easily added back anyway).Closes#1232.
1249b52 to2162785Comparekylecarbs approved these changesMay 12, 2022
presleyp approved these changesMay 12, 2022
Kira-Pilot approved these changesMay 12, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
It appears unclear as of now when/if these will be implemented so Iopted to remove them (as opposed to commenting them out) to avoid havingthem rot (they are easily added back anyway).Closes#1232.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It appears unclear as of now when/if these will be implemented so I
opted to remove them (as opposed to commenting them out) to avoid having
them rot (they are easily added back anyway).
Closes#1232.