Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: correct typo in notification template#14108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intomainfrom17-fix-user-created
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
UPDATE notification_templates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't really see value in restoring the typo in the down migration.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just consistency?

SET
body_template= E'Hi {{.UserName}},\n\New user account **{{.Labels.created_account_name}}** has been created.'
WHERE
id='4e19c0ac-94e1-4532-9515-d1801aa283b2';
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
UPDATE notification_templates
SET
body_template= E'Hi {{.UserName}},\n\nNew user account **{{.Labels.created_account_name}}** has been created.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was incorrectly set in theinitial migration, let's sneak it in here if you don't mind

Suggested change
body_template= E'Hi {{.UserName}},\n\nNew user account **{{.Labels.created_account_name}}** has been created.'
body_template= E'Hi {{.UserName}},\n\nNew user account **{{.Labels.created_account_name}}** has been created.',
group='User Events'

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would rather keep this idempotent. It does not seem to be an urgent fix that requires modifying existing files, and if there are some scripts checking the content of migration files, and I wouldn't like to make them suffer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe you missed the content of the change? The event is a user event, but its group is incorrectly set toWorkspace Events currently.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh crap, let me redo it.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

WHERE
id='4e19c0ac-94e1-4532-9515-d1801aa283b2';
Loading
[8]ページ先頭
©2009-2025 Movatter.jp