Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add notification preferences database & audit support#14100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 20 commits intomainfromdk/notification-prefs/db-audit
Aug 5, 2024

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedAug 1, 2024•
edited
Loading

Part ofcoder/internal#19

NOTE: I used Graphite for this, but it's got too many sharp edges. I'm reverting to manually managing these branches.

This implements the foundation of the feature - namely the database changes, along with auditing support and RBAC - all used in upstack PRs. I initially had these 3 elements in separate branches, but it became too much of a PITA to maintain with Graphite. In the future I'll start with one big branch and decompose before review time instead of decomposing ahead of time.

THIS PR MUST BE MERGED LAST!

@dannykoppingdannykopping changed the titleImplement notification template update auditingfeat: notification preferences database & audit supportAug 1, 2024
@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 1, 2024•
edited
Loading

✅ Meticulous spotted zero visual differences across 468 screens tested:view results.

Expected differences?Click here. Last updated for commit5d683d4. This comment will update as new commits are pushed.

@dannykoppingdannykoppingforce-pushed thedk/notification-prefs/db-audit branch 3 times, most recently from76d4ca5 to85ec862CompareAugust 2, 2024 10:18
@dannykoppingdannykopping changed the titlefeat: notification preferences database & audit supportfeat: add notification preferences database & audit supportAug 2, 2024
@dannykoppingdannykoppingforce-pushed thedk/notification-prefs/db-audit branch from85ec862 to8333dcbCompareAugust 2, 2024 10:25
@dannykoppingdannykopping marked this pull request as ready for reviewAugust 2, 2024 13:58
@dannykoppingdannykoppingforce-pushed thedk/notification-prefs/db-audit branch from8333dcb to93a92d6CompareAugust 2, 2024 14:08
@dannykoppingdannykoppingforce-pushed thedk/notification-prefs/db-audit branch from2105aa4 toc4b8b31CompareAugust 2, 2024 14:39
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

User's haveNotificationPreference which relates toNotificationTemplate. But only admins/owners can setupNotificationTemplate?

Copy link
ContributorAuthor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the review@Emyrk 👍

User's have NotificationPreference which relates to NotificationTemplate. But only admins/owners can setup NotificationTemplate?

Correct; notification templates only store system-level templates right now; the design will evolve to allow operators to create their own notification templates.

Emyrk reacted with thumbs up emoji
@dannykoppingdannykoppingforce-pushed thedk/notification-prefs/db-audit branch 3 times, most recently from6ea0336 to2cc690cCompareAugust 5, 2024 08:00
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some comments below but I don't need to review again.

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
… kindSigned-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykoppingforce-pushed thedk/notification-prefs/db-audit branch from2cc690c toc744d33CompareAugust 5, 2024 11:54
@dannykoppingdannykopping merged commite164b1e intomainAug 5, 2024
33 checks passed
@dannykoppingdannykopping deleted the dk/notification-prefs/db-audit branchAugust 5, 2024 14:18
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkEmyrk left review comments

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dannykopping@johnstcn@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp