NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

refactor: Add vertical space to the footer#1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 1 commit intomainfrombq/add-vertical-spacing-on-footer

May 12, 2022

Merged

refactor: Add vertical space to the footer#1410

BrunoQuaresma merged 1 commit intomainfrombq/add-vertical-spacing-on-footer

May 12, 2022

Conversation

Copy link

Collaborator

BrunoQuaresma commentedMay 12, 2022

Before:

After:

refactor: Add vertical space to the footer

73889da

BrunoQuaresma self-assigned this

May 12, 2022

BrunoQuaresma requested a review froma team as acode owner

May 12, 2022 17:13

Copy link

codecovbot commentedMay 12, 2022•
edited
Loading

Codecov Report

Merging#1410 (73889da) intomain (26b04cc) willincrease coverage by0.03%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1410      +/-   ##==========================================+ Coverage   67.29%   67.32%   +0.03%==========================================  Files         288      288                Lines       19109    19109                Branches      241      241              ==========================================+ Hits        12859    12865       +6+ Misses       4936     4931       -5+ Partials     1314     1313       -1

Flag	Coverage Δ
unittest-go-macos-latest	`54.50% <ø> (-0.07%)`	⬇️
unittest-go-postgres-	`65.87% <ø> (+0.10%)`	⬆️
unittest-go-ubuntu-latest	`56.72% <ø> (-0.06%)`	⬇️
unittest-go-windows-2022	`52.83% <ø> (+0.04%)`	⬆️
unittest-js	`74.19% <ø> (ø)`

Impacted Files	Coverage Δ
site/src/components/Footer/Footer.tsx	`100.00% <ø> (ø)`
site/src/pages/LoginPage/LoginPage.tsx	`91.30% <ø> (ø)`
codersdk/provisionerdaemons.go	`61.97% <0.00%> (-5.64%)`	⬇️
peerbroker/listen.go	`84.03% <0.00%> (-3.37%)`	⬇️
agent/agent.go	`65.90% <0.00%> (-1.24%)`	⬇️
peer/conn.go	`82.80% <0.00%> (+0.49%)`	⬆️
provisionerd/provisionerd.go	`77.51% <0.00%> (+0.53%)`	⬆️
coderd/workspaceagents.go	`57.90% <0.00%> (+1.86%)`	⬆️
provisioner/echo/serve.go	`59.20% <0.00%> (+2.40%)`	⬆️
provisionersdk/serve.go	`43.24% <0.00%> (+8.10%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update26b04cc...73889da. Read thecomment docs.