Jul 23, 2024 · Jul 23, 2024 · Jul 25, 2024 · Jul 26, 2024 · Jul 29, 2024 · Jul 29, 2024
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 return q.db.GetNotificationMessagesByStatus(ctx, arg)
 }

 func (q *querier) GetNotificationTemplateById(ctx context.Context, id uuid.UUID) (database.NotificationTemplate, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationTemplate); err != nil {
 return database.NotificationTemplate{}, err
 }
 return q.db.GetNotificationTemplateById(ctx, id)
 }

 func (q *querier) GetNotificationTemplatesByKind(ctx context.Context, kind database.NotificationTemplateKind) ([]database.NotificationTemplate, error) {
 // TODO: restrict 'system' kind to admins only?
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationTemplate); err != nil {
 return nil, err
 }
 return q.db.GetNotificationTemplatesByKind(ctx, kind)
 }

 func (q *querier) GetNotificationsSettings(ctx context.Context) (string, error) {
 // No authz checks
 return q.db.GetNotificationsSettings(ctx)
 return q.db.GetUserLinksByUserID(ctx, userID)
 }

 func (q *querier) GetUserNotificationPreferences(ctx context.Context, userID uuid.UUID) ([]database.NotificationPreference, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationPreference.WithOwner(userID.String())); err != nil {
 return nil, err
 }
 return q.db.GetUserNotificationPreferences(ctx, userID)
 }

 func (q *querier) GetUserWorkspaceBuildParameters(ctx context.Context, params database.GetUserWorkspaceBuildParametersParams) ([]database.GetUserWorkspaceBuildParametersRow, error) {
 u, err := q.db.GetUserByID(ctx, params.OwnerID)
 if err != nil {
 return q.db.UpdateMemberRoles(ctx, arg)
 }

 func (q *querier) UpdateNotificationTemplateMethodById(ctx context.Context, arg database.UpdateNotificationTemplateMethodByIdParams) (database.NotificationTemplate, error) {
 // TODO: how to restrict this to admins?
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceNotificationTemplate); err != nil {
 return database.NotificationTemplate{}, err
 }
 return q.db.UpdateNotificationTemplateMethodById(ctx, arg)
 }

 func (q *querier) UpdateOAuth2ProviderAppByID(ctx context.Context, arg database.UpdateOAuth2ProviderAppByIDParams) (database.OAuth2ProviderApp, error) {
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceOauth2App); err != nil {
 return database.OAuth2ProviderApp{}, err
 return q.db.UpdateUserLoginType(ctx, arg)
 }

 func (q *querier) UpdateUserNotificationPreferences(ctx context.Context, arg database.UpdateUserNotificationPreferencesParams) (int64, error) {
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceNotificationPreference.WithOwner(arg.UserID.String())); err != nil {
 return -1, err
 }
 return q.db.UpdateUserNotificationPreferences(ctx, arg)
 }

 func (q *querier) UpdateUserProfile(ctx context.Context, arg database.UpdateUserProfileParams) (database.User, error) {
 u, err := q.db.GetUserByID(ctx, arg.ID)
 if err != nil {
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
 files:                     make([]database.File, 0),
 gitSSHKey:                 make([]database.GitSSHKey, 0),
 notificationMessages:      make([]database.NotificationMessage, 0),
 notificationPreferences:   make([]database.NotificationPreference, 0),
 parameterSchemas:          make([]database.ParameterSchema, 0),
 provisionerDaemons:        make([]database.ProvisionerDaemon, 0),
 workspaceAgents:           make([]database.WorkspaceAgent, 0),
 jfrogXRayScans                []database.JfrogXrayScan
 licenses                      []database.License
 notificationMessages          []database.NotificationMessage
 notificationPreferences       []database.NotificationPreference
 oauth2ProviderApps            []database.OAuth2ProviderApp
 oauth2ProviderAppSecrets      []database.OAuth2ProviderAppSecret
 oauth2ProviderAppCodes        []database.OAuth2ProviderAppCode
 return out, nil
 }

 func (*FakeQuerier) GetNotificationTemplateById(_ context.Context, _ uuid.UUID) (database.NotificationTemplate, error) {
 return database.NotificationTemplate{}, ErrUnimplemented
 }

 func (q *FakeQuerier) GetNotificationTemplatesByKind(ctx context.Context, kind database.NotificationTemplateKind) ([]database.NotificationTemplate, error) {
 return nil, ErrUnimplemented
 }

 func (q *FakeQuerier) GetNotificationsSettings(_ context.Context) (string, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()
 return uls, nil
 }

 func (q *FakeQuerier) GetUserNotificationPreferences(_ context.Context, userID uuid.UUID) ([]database.NotificationPreference, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()

 out := make([]database.NotificationPreference, 0, len(q.notificationPreferences))
 for _, np := range q.notificationPreferences {
 if np.UserID != userID {
 continue
 }

 out = append(out, np)
 }

 return out, nil
 }

 func (q *FakeQuerier) GetUserWorkspaceBuildParameters(_ context.Context, params database.GetUserWorkspaceBuildParametersParams) ([]database.GetUserWorkspaceBuildParametersRow, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()
 return database.OrganizationMember{}, sql.ErrNoRows
 }

 func (*FakeQuerier) UpdateNotificationTemplateMethodById(_ context.Context, _ database.UpdateNotificationTemplateMethodByIdParams) (database.NotificationTemplate, error) {
 return database.NotificationTemplate{}, ErrUnimplemented
 }

 func (q *FakeQuerier) UpdateOAuth2ProviderAppByID(_ context.Context, arg database.UpdateOAuth2ProviderAppByIDParams) (database.OAuth2ProviderApp, error) {
 err := validateDatabaseType(arg)
 if err != nil {
 return database.User{}, sql.ErrNoRows
 }

 func (q *FakeQuerier) UpdateUserNotificationPreferences(_ context.Context, arg database.UpdateUserNotificationPreferencesParams) (int64, error) {
 err := validateDatabaseType(arg)
 if err != nil {
 return -1, err
 }

 q.mutex.Lock()
 defer q.mutex.Unlock()

 var upserted int64
 for i := range arg.NotificationTemplateIds {
 var (
 found      bool
 templateID = arg.NotificationTemplateIds[i]
 disabled   = arg.Disableds[i]
 )

 for j, np := range q.notificationPreferences {
 if np.UserID != arg.UserID {
 continue
 }

 if np.NotificationTemplateID != templateID {
 continue
 }

 np.Disabled = disabled
 np.UpdatedAt = time.Now()
 q.notificationPreferences[j] = np

 upserted++
 found = true
 break
 }

 if !found {
 np := database.NotificationPreference{
 Disabled:               disabled,
 UserID:                 arg.UserID,
 NotificationTemplateID: templateID,
 CreatedAt:              time.Now(),
 UpdatedAt:              time.Now(),
 }
 q.notificationPreferences = append(q.notificationPreferences, np)
 upserted++
 }
 }

 return upserted, nil
 }

 func (q *FakeQuerier) UpdateUserProfile(_ context.Context, arg database.UpdateUserProfileParams) (database.User, error) {
 if err := validateDatabaseType(arg); err != nil {
 return database.User{}, err
diff --git a/coderd/database/dbmetrics/dbmetrics.go b/coderd/database/dbmetrics/dbmetrics.go
diff --git a/coderd/database/dbmock/dbmock.go b/coderd/database/dbmock/dbmock.go
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1474,6 +1474,21 @@ func (q *querier) GetNotificationMessagesByStatus(ctx context.Context, arg datab
		return q.db.GetNotificationMessagesByStatus(ctx, arg)
		}

		func (q *querier) GetNotificationTemplateById(ctx context.Context, id uuid.UUID) (database.NotificationTemplate, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationTemplate); err != nil {
		return database.NotificationTemplate{}, err
		}
		return q.db.GetNotificationTemplateById(ctx, id)
		}

		func (q *querier) GetNotificationTemplatesByKind(ctx context.Context, kind database.NotificationTemplateKind) ([]database.NotificationTemplate, error) {
		// TODO: restrict 'system' kind to admins only?
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationTemplate); err != nil {
		return nil, err
		}
		return q.db.GetNotificationTemplatesByKind(ctx, kind)
		}

		func (q *querier) GetNotificationsSettings(ctx context.Context) (string, error) {
		// No authz checks
		return q.db.GetNotificationsSettings(ctx)
Expand DownExpand Up		@@ -2085,6 +2100,13 @@ func (q *querier) GetUserLinksByUserID(ctx context.Context, userID uuid.UUID) ([
		return q.db.GetUserLinksByUserID(ctx, userID)
		}

		func (q *querier) GetUserNotificationPreferences(ctx context.Context, userID uuid.UUID) ([]database.NotificationPreference, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationPreference.WithOwner(userID.String())); err != nil {
		return nil, err
		}
		return q.db.GetUserNotificationPreferences(ctx, userID)
		}

		func (q *querier) GetUserWorkspaceBuildParameters(ctx context.Context, params database.GetUserWorkspaceBuildParametersParams) ([]database.GetUserWorkspaceBuildParametersRow, error) {
		u, err := q.db.GetUserByID(ctx, params.OwnerID)
		if err != nil {
Expand DownExpand Up		@@ -3011,6 +3033,14 @@ func (q *querier) UpdateMemberRoles(ctx context.Context, arg database.UpdateMemb
		return q.db.UpdateMemberRoles(ctx, arg)
		}

		func (q *querier) UpdateNotificationTemplateMethodById(ctx context.Context, arg database.UpdateNotificationTemplateMethodByIdParams) (database.NotificationTemplate, error) {
		// TODO: how to restrict this to admins?
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceNotificationTemplate); err != nil {
		return database.NotificationTemplate{}, err
		}
		return q.db.UpdateNotificationTemplateMethodById(ctx, arg)
		}

		func (q *querier) UpdateOAuth2ProviderAppByID(ctx context.Context, arg database.UpdateOAuth2ProviderAppByIDParams) (database.OAuth2ProviderApp, error) {
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceOauth2App); err != nil {
		return database.OAuth2ProviderApp{}, err
Expand DownExpand Up		@@ -3309,6 +3339,13 @@ func (q *querier) UpdateUserLoginType(ctx context.Context, arg database.UpdateUs
		return q.db.UpdateUserLoginType(ctx, arg)
		}

		func (q *querier) UpdateUserNotificationPreferences(ctx context.Context, arg database.UpdateUserNotificationPreferencesParams) (int64, error) {
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceNotificationPreference.WithOwner(arg.UserID.String())); err != nil {
		return -1, err
		}
		return q.db.UpdateUserNotificationPreferences(ctx, arg)
		}

		func (q *querier) UpdateUserProfile(ctx context.Context, arg database.UpdateUserProfileParams) (database.User, error) {
		u, err := q.db.GetUserByID(ctx, arg.ID)
		if err != nil {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -65,6 +65,7 @@ func New() database.Store {
		files: make([]database.File, 0),
		gitSSHKey: make([]database.GitSSHKey, 0),
		notificationMessages: make([]database.NotificationMessage, 0),
		notificationPreferences: make([]database.NotificationPreference, 0),
		parameterSchemas: make([]database.ParameterSchema, 0),
		provisionerDaemons: make([]database.ProvisionerDaemon, 0),
		workspaceAgents: make([]database.WorkspaceAgent, 0),
Expand DownExpand Up		@@ -160,6 +161,7 @@ type data struct {
		jfrogXRayScans []database.JfrogXrayScan
		licenses []database.License
		notificationMessages []database.NotificationMessage
		notificationPreferences []database.NotificationPreference
		oauth2ProviderApps []database.OAuth2ProviderApp
		oauth2ProviderAppSecrets []database.OAuth2ProviderAppSecret
		oauth2ProviderAppCodes []database.OAuth2ProviderAppCode
Expand DownExpand Up		@@ -2708,6 +2710,14 @@ func (q *FakeQuerier) GetNotificationMessagesByStatus(_ context.Context, arg dat
		return out, nil
		}

		func (*FakeQuerier) GetNotificationTemplateById(_ context.Context, _ uuid.UUID) (database.NotificationTemplate, error) {
		return database.NotificationTemplate{}, ErrUnimplemented
		}

		func (q *FakeQuerier) GetNotificationTemplatesByKind(ctx context.Context, kind database.NotificationTemplateKind) ([]database.NotificationTemplate, error) {
		return nil, ErrUnimplemented
		}

		func (q *FakeQuerier) GetNotificationsSettings(_ context.Context) (string, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()
Expand DownExpand Up		@@ -4853,6 +4863,22 @@ func (q *FakeQuerier) GetUserLinksByUserID(_ context.Context, userID uuid.UUID)
		return uls, nil
		}

		func (q *FakeQuerier) GetUserNotificationPreferences(_ context.Context, userID uuid.UUID) ([]database.NotificationPreference, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()

		out := make([]database.NotificationPreference, 0, len(q.notificationPreferences))
		for _, np := range q.notificationPreferences {
		if np.UserID != userID {
		continue
		}

		out = append(out, np)
		}

		return out, nil
		}

		func (q *FakeQuerier) GetUserWorkspaceBuildParameters(_ context.Context, params database.GetUserWorkspaceBuildParametersParams) ([]database.GetUserWorkspaceBuildParametersRow, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()
Expand DownExpand Up		@@ -7520,6 +7546,10 @@ func (q *FakeQuerier) UpdateMemberRoles(_ context.Context, arg database.UpdateMe
		return database.OrganizationMember{}, sql.ErrNoRows
		}

		func (*FakeQuerier) UpdateNotificationTemplateMethodById(_ context.Context, _ database.UpdateNotificationTemplateMethodByIdParams) (database.NotificationTemplate, error) {
		return database.NotificationTemplate{}, ErrUnimplemented
		}

		func (q *FakeQuerier) UpdateOAuth2ProviderAppByID(_ context.Context, arg database.UpdateOAuth2ProviderAppByIDParams) (database.OAuth2ProviderApp, error) {
		err := validateDatabaseType(arg)
		if err != nil {
Expand DownExpand Up		@@ -8094,6 +8124,57 @@ func (q *FakeQuerier) UpdateUserLoginType(_ context.Context, arg database.Update
		return database.User{}, sql.ErrNoRows
		}

		func (q *FakeQuerier) UpdateUserNotificationPreferences(_ context.Context, arg database.UpdateUserNotificationPreferencesParams) (int64, error) {
		err := validateDatabaseType(arg)
		if err != nil {
		return -1, err
		}

		q.mutex.Lock()
		defer q.mutex.Unlock()

		var upserted int64
		for i := range arg.NotificationTemplateIds {
		var (
		found bool
		templateID = arg.NotificationTemplateIds[i]
		disabled = arg.Disableds[i]
		)

		for j, np := range q.notificationPreferences {
		if np.UserID != arg.UserID {
		continue
		}

		if np.NotificationTemplateID != templateID {
		continue
		}

		np.Disabled = disabled
		np.UpdatedAt = time.Now()
		q.notificationPreferences[j] = np

		upserted++
		found = true
		break
		}

		if !found {
		np := database.NotificationPreference{
		Disabled: disabled,
		UserID: arg.UserID,
		NotificationTemplateID: templateID,
		CreatedAt: time.Now(),
		UpdatedAt: time.Now(),
		}
		q.notificationPreferences = append(q.notificationPreferences, np)
		upserted++
		}
		}

		return upserted, nil
		}

		func (q *FakeQuerier) UpdateUserProfile(_ context.Context, arg database.UpdateUserProfileParams) (database.User, error) {
		if err := validateDatabaseType(arg); err != nil {
		return database.User{}, err
Expand Down