Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add sql filter to fetching audit logs#14070

Merged
Emyrk merged 8 commits intomainfrom
stevenmasley/audit_log_sql_filter
Aug 1, 2024
Merged

chore: add sql filter to fetching audit logs#14070
Emyrk merged 8 commits intomainfrom
stevenmasley/audit_log_sql_filter

Conversation

@Emyrk
Copy link
Member

@EmyrkEmyrk commentedJul 31, 2024
edited
Loading

What this does

This adds a SQL filter to fetching audit logs. Prior to this change, all audit logs shared the same authorization call, so only 1 was done up front. Now that we have organizational scoped audit logs, listing all audit logs a user can view will operate like workspaces.

The SQL filter is required for pagination, as the filtering has to occur in the database.

@alwaysmeticulous
Copy link

alwaysmeticulousbot commentedJul 31, 2024
edited
Loading

🤖 Meticulous replayed 100 user sessions andtook 759 visual snapshots. Meticulous has not yet run on956d0cb of the main branch and so there was nothing to compare against.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons fornew pull requests after the next commit to the main branch.

Last updated for commit2709d4b. This comment will update as new commits are pushed.

@EmyrkEmyrk marked this pull request as ready for reviewJuly 31, 2024 21:44
@EmyrkEmyrk requested a review fromjohnstcnJuly 31, 2024 22:07
@EmyrkEmyrk merged commita27ac30 intomainAug 1, 2024
@EmyrkEmyrk deleted the stevenmasley/audit_log_sql_filter branchAugust 1, 2024 17:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@dannykoppingdannykoppingAwaiting requested review from dannykopping

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Emyrk@johnstcn

[8]ページ先頭

©2009-2026 Movatter.jp