NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: add sql filter to fetching audit logs#14070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Emyrk merged 8 commits intomainfromstevenmasley/audit_log_sql_filter

Aug 1, 2024

Merged

chore: add sql filter to fetching audit logs#14070

Emyrk merged 8 commits intomainfromstevenmasley/audit_log_sql_filter

Aug 1, 2024

Conversation

Copy link

Member

Emyrk commentedJul 31, 2024•
edited
Loading

What this does

This adds a SQL filter to fetching audit logs. Prior to this change, all audit logs shared the same authorization call, so only 1 was done up front. Now that we have organizational scoped audit logs, listing all audit logs a user can view will operate like workspaces.

The SQL filter is required for pagination, as the filtering has to occur in the database.

Emyrk added2 commits

July 31, 2024 12:46

chore: add sql filter to fetching audit logs

796d615

use sqlc.embed for audit logs

c99cc31

github-actionsbot assignedEmyrk

Jul 31, 2024

Copy link

alwaysmeticulousbot commentedJul 31, 2024•
edited
Loading

🤖 Meticulous replayed 100 user sessions andtook 759 visual snapshots. Meticulous has not yet run on956d0cb of the main branch and so there was nothing to compare against.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons fornew pull requests after the next commit to the main branch.

_{Last updated for commit2709d4b. This comment will update as new commits are pushed.}