🤖 Meticulous replayed 100 user sessions andtook 1258 visual snapshots. Meticulous has not yet run on238e995 of the main branch and so there was nothing to compare against.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons fornew pull requests after the next commit to the main branch.

_{Last updated for commit72f1bab. This comment will update as new commits are pushed.}

I will rely on@aslilac review for the FE code and focus on the design and QA.

1. If a form does not have more than one section, it should be a simple vertical form. I also would add a subtitle to the header.

2. For the checkbox group, what do you think about having something like what we are using fornotifications? Of course, replace it with the permissions primary and secondary text, and remove the icon on the right.

@BrunoQuaresma Regarding using switches for organization roles similar to notifications.

1. FYI, I have been using the github example below as a reference. I feel like roles are conceptually different to notifications because roles are a set of things a users does or does not possess, whereas notifications feel like something that is turned on/off. I also did a quick survey of other tools and found that Azure, Github and many others use check boxes so my feeling is that it is a more common design pattern for managing custom roles.

2. I am guessing that an API call is made every time a switch is changed for notifications. For roles, I imagined that the user would go through the flow of checking all the relevant roles and submitting the changes because it felt like creating a set of things as opposed to switching individual settings on/off. Although, I do think there could be value in making each change in the checkbox send the patch request instead of waiting to press the submit button if others agree.

@BrunoQuaresma regarding the form only having one section, I still need to add the delete role functionality and was thinking of doing it like organization settings. Unless, you have any thoughts about a better place to delete roles?

Related to the checkboxes: I think using GitHub as a reference is a good idea, but I missed a few things like the alignment of the descriptions and the "header checkbox" to check or uncheck the children options.

Related to the delete section: I don't think we need it on the create page right? Also, the width page for those settings pages is smaller because the sidebar does not give proper space to a horizontal form. Even using two sections, we can still use vertical forms. GH does this very well on their settings pages.

I will leave those decisions up to you.

While QAing it I recorded a video to share a few design things that could be improved.

@aslilac I made all the changes planned for this PR based on the suggestions. Design improvements for checkboxes and delete custom role will be completed in a separate PR.