Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: document RBAC usage#14065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 11 commits intomainfromdk/rbacdoc
Sep 10, 2024
Merged

chore: document RBAC usage#14065

dannykopping merged 11 commits intomainfromdk/rbacdoc
Sep 10, 2024

Conversation

dannykopping
Copy link
Contributor

Uses#14055 (credit to@johnstcn!) as a reference to demonstrate the use of the RBAC system.

matifali reacted with rocket emoji
@alwaysmeticulousalwaysmeticulous

This comment was marked as outdated.

@dannykoppingdannykopping changed the titleDocument RBAC usagechore: document RBAC usageJul 31, 2024
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This overall looks good. The one missing piece isRBACObject() and the organizational scoping.

Something to note, if you useInOrg(), then youmust be a member of the organization as well. What this means is if you have the user Alice make a workspace Worble in organization Orange, and Alice leaves the org, she can no longer use the workspace.

Despite having the user permission to do so.

This is stated here in the rego:

# If we are not a member of an org, and the object has an org, then we are
# not authorized. This is an "implied -1" for not being in the org.
org_ok

So the truth table for not being in an org (if the resource belongs to an org) has aNegative in theOrg column.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelAug 9, 2024
@johnstcnjohnstcn reopened thisAug 12, 2024
@johnstcnjohnstcn removed the staleThis issue is like stale bread. labelAug 12, 2024
@dannykopping
Copy link
ContributorAuthor

@johnstcn thanks for reopening; I'll try get to this today or tomorrow.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelAug 27, 2024
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelSep 4, 2024
dannykoppingand others added8 commitsSeptember 10, 2024 11:14
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
- Truth table had an incorrect result value in final row- Permission format examples was missing the object type- Fix actions list- Code block a bash command
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
(cherry picked from commit66c8060)Co-authored-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Thanks for taking this on@dannykopping !

Co-authored-by: Cian Johnston <cian@coder.com>
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love all this ❤️

Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
@dannykoppingdannykoppingenabled auto-merge (squash)September 10, 2024 14:36
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykopping merged commit914f35a intomainSep 10, 2024
26 checks passed
@dannykoppingdannykopping deleted the dk/rbacdoc branchSeptember 10, 2024 15:15
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@dannykopping@johnstcn@Emyrk@stirby
[8]ページ先頭
©2009-2025 Movatter.jp