Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: block creating oidc users when oidc has not been configured#14064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJul 31, 2024•
edited
Loading

Discovered as it was possible to cause an (albeit recoverable) nil dereference when updating the roles of an OIDC user when OIDC had not yet been configured.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedJul 31, 2024•
edited
Loading

✅ Meticulous spotted zero visual differences across 932 screens tested:view results.

Expected differences?Click here. Last updated for commit6585dc2. This comment will update as new commits are pushed.

@ethanndicksonethanndickson marked this pull request as ready for reviewJuly 31, 2024 12:16
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch! 👍

A unit test would be great, but not required. I can add one later.

@ethanndicksonethanndicksonforce-pushed the07-31-fix_block_creating_oidc_users_when_oidc_has_not_been_configured branch from663a3ba to6585dc2CompareAugust 1, 2024 03:10
@ethanndicksonethanndickson merged commit956d0cb intomainAug 1, 2024
30 checks passed
@ethanndicksonethanndickson deleted the 07-31-fix_block_creating_oidc_users_when_oidc_has_not_been_configured branchAugust 1, 2024 03:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@kylecarbskylecarbskylecarbs approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ethanndickson@Emyrk@kylecarbs@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp