- Notifications
You must be signed in to change notification settings - Fork928
feat(site): allow selecting an organization when creating a template#14061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code looks good to me. I will try to run it locally, and if I need any help with that, I will ping you. I think something useful would be adding in the description, a step-by-step tutorial to get it running.
After reading the PR description again, I can see how difficult it can be to test locally. I think our tests can catch most of the bugs we may have so I will move forward and approve the PR but please let me know if you want a QA on dev.coder.com when it gets merged. |
ok, this is basically ready to merge, but I need to do a little bit of tweaking with links and navigation that I think would probably be better off in a separate PR, rather than making this one even larger. |
7125b37 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closes#13877
Closes#13879
This PR is kind of massive because all of the existing template views assume that the template you're looking at is in the default org. Allowing creating a template under any org, means all of this UI needs to be updated, some tests need to change, etc. This even sparked a pretty large backend change (tho that became its own PR and has already been merged).
Important note (reviewers, seriously please read this)
You currently cannot find the template you created in the UI on the /templates page. This is intentional! That work was already completed in a different PR, which unfortunately got reverted. This change is purely to enable creating templates in other orgs, and is already large. The rest of the flow will come (back) later. :)
Make sure you have a provisioner connected to whatever org you want to create a template for if you try kicking the tires on this. This requires some manual effort and know-how, so please let me know if you need help testing.