Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(site): allow selecting an organization when creating a template#14061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 65 commits intomainfromkayla/multi-org-create-template
Aug 2, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJul 30, 2024
edited
Loading

Closes#13877
Closes#13879

This PR is kind of massive because all of the existing template views assume that the template you're looking at is in the default org. Allowing creating a template under any org, means all of this UI needs to be updated, some tests need to change, etc. This even sparked a pretty large backend change (tho that became its own PR and has already been merged).

Screenshot 2024-07-30 at 3 28 12 PM

Important note (reviewers, seriously please read this)

  1. You currently cannot find the template you created in the UI on the /templates page. This is intentional! That work was already completed in a different PR, which unfortunately got reverted. This change is purely to enable creating templates in other orgs, and is already large. The rest of the flow will come (back) later. :)

  2. Make sure you have a provisioner connected to whatever org you want to create a template for if you try kicking the tires on this. This requires some manual effort and know-how, so please let me know if you need help testing.

@aslilacaslilac requested a review fromjaaydenhJuly 30, 2024 22:01
@aslilacaslilac marked this pull request as ready for reviewJuly 30, 2024 22:01
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good to me. I will try to run it locally, and if I need any help with that, I will ping you. I think something useful would be adding in the description, a step-by-step tutorial to get it running.

@BrunoQuaresma
Copy link
Collaborator

After reading the PR description again, I can see how difficult it can be to test locally. I think our tests can catch most of the bugs we may have so I will move forward and approve the PR but please let me know if you want a QA on dev.coder.com when it gets merged.

@aslilac
Copy link
MemberAuthor

ok, this is basically ready to merge, but I need to do a little bit of tweaking with links and navigation that I think would probably be better off in a separate PR, rather than making this one even larger.

@aslilacaslilac merged commit7125b37 intomainAug 2, 2024
31 checks passed
@aslilacaslilac deleted the kayla/multi-org-create-template branchAugust 2, 2024 00:04
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@EmyrkEmyrkAwaiting requested review from Emyrk

@jaaydenhjaaydenhAwaiting requested review from jaaydenh

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-org create template form
3 participants
@aslilac@BrunoQuaresma@jaaydenh

[8]ページ先頭

©2009-2025 Movatter.jp