Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: always use new codepath over deprecated#14050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedJul 30, 2024•
edited
Loading

Do not use deprecated endpoints in tests. Maybe we should keep a legacy test or two?

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedJul 30, 2024•
edited
Loading

✅ Meticulous spotted zero visual differences across 1072 screens tested:view results.

Expected differences?Click here. Last updated for commit ca28cea. This comment will update as new commits are pushed.

@EmyrkEmyrk marked this pull request as ready for reviewJuly 30, 2024 03:14
@EmyrkEmyrk requested a review fromaslilacJuly 30, 2024 13:26
Comment on lines +490 to 502
ifhttpapi.Is404Error(err) {
httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe we should actually send ahttp.StatusNotFound for this then

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since it the request is trying to create a workspace, I am not sure if a 404 makes much sense to the caller? The error indicates why the request failed, being the template does not exist.

Comment on lines +478 to +479
func (c *Client) CreateWorkspace(ctx context.Context, _ uuid.UUID, user string, request CreateWorkspaceRequest) (Workspace, error) {
return c.CreateUserWorkspace(ctx, user, request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice approach!

@EmyrkEmyrkforce-pushed thestevenmasley/post-workspace-by-user branch froma583cd5 to005dcd3CompareJuly 30, 2024 14:48
@EmyrkEmyrk merged commit708557d intopost-workspace-by-userJul 30, 2024
30 checks passed
@EmyrkEmyrk deleted the stevenmasley/post-workspace-by-user branchJuly 30, 2024 15:19
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp