Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(coderd): allow creating workspaces without specifying an organization#14048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 8 commits intomainfrompost-workspace-by-user
Jul 30, 2024

Conversation

aslilac
Copy link
Member

The organization can always be inferred from the template, which makes the parameter redundant. Templates are guaranteed to always belong to a single organization. The only purpose the organization parameter served in the old endpoint was a validation check to make sure that it matched the organization we inferred from the template.

  • Deprecate the old endpoint
  • Add a new endpoint at/users/{user}/workspaces [post]

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedJul 29, 2024
edited
Loading

Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR.

Last updated for commit708557d. This comment will update as new commits are pushed.

aslilacand others added2 commitsJuly 30, 2024 14:30
* chore: always use new codepath over deprecated* add unit test for lack of template access
@aslilacaslilac merged commitbf4b7ab intomainJul 30, 2024
33 checks passed
@aslilacaslilac deleted the post-workspace-by-user branchJuly 30, 2024 16:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 30, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp