Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update generated files after pnpm upgrade#14036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 3 commits intomainfromdk/make-gen-pnpm
Jul 31, 2024

Conversation

dannykopping
Copy link
Contributor

I'm unsure howmain got into this state, but when runningmake gen in one of my branches it produces diffs in these files.

@coadler maybe you know? I guess this should've changed after#13843 so maybe ourmake gen target is buggy?

Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping
Copy link
ContributorAuthor

Not really sure why CI is failing.

@coadler
Copy link
Contributor

Sorry about taking a bit to review, I think the reason it's failing is bc I neglected to update pnpm in CI. That should fix it

@dannykopping
Copy link
ContributorAuthor

No worries@coadler 👍
Any idea why CI is failing with this error?

 ERR_PNPM_NO_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is absent

https://github.com/coder/coder/actions/runs/10143062920/job/28043671521?pr=14036

@coadler
Copy link
Contributor

I think the bump from v8 -> v9 changed lockfile formats, so maybe that's what v8 errors with when it sees the new format?

@dannykopping
Copy link
ContributorAuthor

Any idea how to resolve it?

@coadler
Copy link
Contributor

https://github.com/coder/coder/blob/main/.github/actions/setup-node/action.yaml#L168 ->9 I think

dannykopping reacted with eyes emoji

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedJul 31, 2024
edited
Loading

✅ Meticulous spotted zero visual differences across 1072 screens tested:view results.

Expected differences?Click here. Last updated for commit5d720b4. This comment will update as new commits are pushed.

@dannykoppingdannykopping merged commitc339099 intomainJul 31, 2024
33 checks passed
@dannykoppingdannykopping deleted the dk/make-gen-pnpm branchJuly 31, 2024 15:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 31, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@coadlercoadlercoadler approved these changes

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dannykopping@coadler

[8]ページ先頭

©2009-2025 Movatter.jp