- Notifications
You must be signed in to change notification settings - Fork927
chore: update generated files after pnpm upgrade#14036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Not really sure why CI is failing. |
Sorry about taking a bit to review, I think the reason it's failing is bc I neglected to update pnpm in CI. That should fix it |
No worries@coadler 👍
https://github.com/coder/coder/actions/runs/10143062920/job/28043671521?pr=14036 |
I think the bump from v8 -> v9 changed lockfile formats, so maybe that's what v8 errors with when it sees the new format? |
Any idea how to resolve it? |
Signed-off-by: Danny Kopping <danny@coder.com>
alwaysmeticulousbot commentedJul 31, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Meticulous spotted zero visual differences across 1072 screens tested:view results. Expected differences?Click here. Last updated for commit5d720b4. This comment will update as new commits are pushed. |
c339099
intomainUh oh!
There was an error while loading.Please reload this page.
I'm unsure how
main
got into this state, but when runningmake gen
in one of my branches it produces diffs in these files.@coadler maybe you know? I guess this should've changed after#13843 so maybe our
make gen
target is buggy?