All contributors have signed the CLA ✍️ ✅
_{Posted by theCLA Assistant Lite bot.}

I have read the CLA Document and I hereby sign the CLA

recheck

I agree with the overall intent, but Kubernetes PVCs have a length limit of 63 characters. Theworkspace_instance local will be 73 characters long as it consists of 2 UUIDs joined by a hyphen.

How about we instead usedata.coder_workspace.me.id to act as a stable identifier?

Good catch, I thinkdata.coder_workspace.me.id is good for the PVC name. Do you think there's any reason to keepworkspace_instance for the labels or should I just make everything use the workspace ID?

Good catch, I thinkdata.coder_workspace.me.id is good for the PVC name. Do you think there's any reason to keepworkspace_instance for the labels or should I just make everything use the workspace ID?

I think you'll run into the same issue if you try to use thatworkspace_instance local as a label value:

A label key and value must begin with a letter or number, and may contain letters, numbers, hyphens, dots, and underscores, up to 63 characters each.

https://kubernetes.io/docs/reference/kubectl/generated/kubectl_label/

Sorry I didn't realise labels had the same restriction. I've changed everything to just use the workspace ID.

@geniass, it looks like CLA is still not signed by you. This can happen if your GitHub email and your commuter email are different.

recheck