- Notifications
You must be signed in to change notification settings - Fork928
chore: embed audit log in deployment settings page#14023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The existing link remains but will redirect to the new URL.
Otherwise the input is teeny tiny and barely fits a few characters.
code-asher commentedJul 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@bcpeinhardt it auto-assigned you when I selected the ts group but no pressure (unless you want to review); I am going to reassign to someone on 🍌 |
Only for multi-org; single-org setups remain unaffected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Finishing#13958 should be pretty easy (only needs some changes in Sidebar.tsx)
I'd also like to tweak the styles a little before closing that ticket, but this is a great step forward. 😄
Uh oh!
There was an error while loading.Please reload this page.
| export function withFilter(path: string, filter: string) { | ||
| return path + (filter ? `?filter=${encodeURIComponent(filter)}` : ""); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
:chefskiss:
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
712662d intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The first thing is moving the audit log from
/auditto/deployment/auditwhen multi-org is enabled. Although we have a redirect in place for the old URL, I changed the deployment dropdown link to go directly to the new spot (I also tweak the users link while I was there to do the same).The second thing is making the per-org auditing links go to the main audit log with a pre-filled organization. Note this conflicts with the description in#13958 but fulfills#13913. I think we will probably want to revisit and decide what exactly we want to do here. I have many thoughts. :D
The third thing is to make the filters wrap immediately when on the settings page because the text input is too small otherwise. For comparison:
And fourth, the information is now in a tooltip while under multi-org. This is to compensate for the sidebar and for the extra organization information.
There should be no changes without multi-org enabled (except the flex-grow making the filter menus expand when on smaller screens).
Part 1 of#13958
Part 3 of andcloses#13913