Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: missing return when template version is not found#1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 1 commit intomainfromasher/missing-return
May 11, 2022

Conversation

code-asher
Copy link
Member

Split out from#1394 for changelog purposes

@greyscaledgreyscaled changed the titleAdd missing return when template version is not foundfix: missing return when template version is not foundMay 11, 2022
@codecov
Copy link

codecovbot commentedMay 11, 2022
edited
Loading

Codecov Report

Merging#1402 (f5d1b62) intomain (982769f) willdecrease coverage by0.02%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1402      +/-   ##==========================================- Coverage   66.90%   66.87%   -0.03%==========================================  Files         288      287       -1       Lines       18857    18851       -6       Branches      241      241              ==========================================- Hits        12616    12607       -9- Misses       4949     4950       +1- Partials     1292     1294       +2
FlagCoverage Δ
unittest-go-macos-latest53.97% <100.00%> (-0.07%)⬇️
unittest-go-postgres-65.44% <100.00%> (+0.07%)⬆️
unittest-go-ubuntu-latest56.37% <100.00%> (-0.13%)⬇️
unittest-go-windows-202252.32% <100.00%> (-0.06%)⬇️
unittest-js74.24% <ø> (ø)
Impacted FilesCoverage Δ
coderd/organizations.go56.23% <100.00%> (-1.01%)⬇️
coderd/turnconn/turnconn.go81.91% <0.00%> (-3.20%)⬇️
peer/conn.go79.36% <0.00%> (-1.72%)⬇️
codersdk/workspaceagents.go51.52% <0.00%> (-1.36%)⬇️
cli/templates.go100.00% <0.00%> (ø)
site/src/components/UserDropdown/UsersDropdown.tsx96.15% <0.00%> (ø)
cli/templateedit.go
site/src/testHelpers/index.tsx
site/src/api/index.ts
... and6 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update982769f...f5d1b62. Read thecomment docs.

@code-ashercode-asher merged commitce660f8 intomainMay 11, 2022
@code-ashercode-asher deleted the asher/missing-return branchMay 11, 2022 22:58
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

4 participants
@code-asher@greyscaled@Kira-Pilot@misskniss

[8]ページ先頭

©2009-2025 Movatter.jp