Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: manage groups from deployment settings for single-org deployments#14016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 8 commits intomainfromnon-org-groups
Jul 26, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJul 25, 2024•
edited
Loading

Closes#13957

Screenshot 2024-07-25 at 12 30 46 PM

@aslilacaslilac changed the titlefeat: manage non-multi-org groups from deployment settingsfeat: manage groups from deployment settings for single-org deploymentsJul 25, 2024
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just to make sure I understand "single-org" in this context, that is with the multi-org experiment enabled but not licensed, right?

Should we redirect/groups to/deployment/groups (or/organizations/default/groups/ for multi-org?) similar to the users page? Probably not very important, but if someone has a bookmark or tries typing it manually maybe.

I think the create group page needs to take me to/deployment/groups/groupname rather than/organizations/default/groups/groupname with single-org since the latter gives me a blank sidebar (maybe a good place for another relative redirect).

Looks good so far!

BrunoQuaresma reacted with thumbs up emoji
@@ -50,7 +50,7 @@ import { isEveryoneGroup } from "utils/groups";
import { pageTitle } from "utils/page";

export const GroupPage: FC = () => {
const { organization, groupName } = useParams() as {
const { organization = "default", groupName } = useParams() as {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see the constant "default" used in multiple places. We should define it in aconst.ts file for consistency. Makes sense?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

personally, I really dread adding imports like that which end up being more typing that the thing you could just say directly

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commentedJul 26, 2024•
edited
Loading

Just to make sure I understand "single-org" in this context, that is with the multi-org experiment enabled but not licensed, right?

@code-asher I think it is also true when there is only one org created.

@BrunoQuaresma
Copy link
Collaborator

  1. When I go to Deployment > Organizations, the sidebar is hidden. It looks strange to me; I would prefer to see it open.
Screenshot 2024-07-26 at 10 09 55
  1. It is not related to this particular PR, but I've been finding it hard to determine the currently active menu in the sidebar due to the numerous options available. Maybe we could style the active option differently?
Screenshot 2024-07-26 at 10 11 26
  1. I have a license and multi-org enabled, but I can't create new orgs. Perhaps it's related to 1?
Screenshot 2024-07-26 at 10 13 40Screenshot 2024-07-26 at 10 14 40Screenshot 2024-07-26 at 10 13 49

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm missing tests for the changes so we can be sure we are not introducing bugs while moving forward.

@aslilac
Copy link
MemberAuthor

I think it is also true when there is only one org created.

No, a deployment which only has one org created but has a multi-org license is still a multi-org deployment. We need to show the "New organization" button, for example which is only present in the multi-org version of the UI. (and maintaining a 3rd version of the UI that's half single-org and half multi-org would be a gigantic pain)

BrunoQuaresma reacted with thumbs up emoji

@aslilac
Copy link
MemberAuthor

I have a license and multi-org enabled, but I can't create new orgs.

there are two license types now, and old/enterprise licenses no longer have access to org features. you can get a "premium" one from notion to test with. :)

BrunoQuaresma reacted with thumbs up emoji

@aslilacaslilac merged commitd68340b intomainJul 26, 2024
30 checks passed
@aslilacaslilac deleted the non-org-groups branchJuly 26, 2024 19:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@code-ashercode-ashercode-asher left review comments

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate all users view into the multi-org capableManagementSettingsPage
3 participants
@aslilac@BrunoQuaresma@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp