Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add eslint extension recommendation#1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 1 commit intomainfromadd-eslint-to-recommendations/kira-pilot
May 11, 2022

Conversation

Kira-Pilot
Copy link
Member

Resolves#1399.

Screen Shot 2022-05-11 at 4 43 54 PM

@Kira-PilotKira-Pilot requested a review froma teamMay 11, 2022 21:40
Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this!

Kira-Pilot reacted with thumbs up emoji
@codecov
Copy link

codecovbot commentedMay 11, 2022•
edited
Loading

Codecov Report

Merging#1400 (49fa840) intomain (be3bc5c) willincrease coverage by0.01%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1400      +/-   ##==========================================+ Coverage   66.94%   66.96%   +0.01%==========================================  Files         287      287                Lines       18850    18850                Branches      241      241              ==========================================+ Hits        12620    12622       +2  Misses       4940     4940+ Partials     1290     1288       -2
FlagCoverage Δ
unittest-go-macos-latest54.18% <ø> (+0.08%)⬆️
unittest-go-postgres-65.36% <ø> (-0.07%)⬇️
unittest-go-ubuntu-latest56.39% <ø> (-0.05%)⬇️
unittest-go-windows-202252.42% <ø> (+0.05%)⬆️
unittest-js74.24% <ø> (ø)
Impacted FilesCoverage Δ
provisionersdk/serve.go35.13% <0.00%> (-8.11%)⬇️
cli/cliui/agent.go77.46% <0.00%> (-4.23%)⬇️
peerbroker/listen.go84.03% <0.00%> (-3.37%)⬇️
coderd/workspaceagents.go55.34% <0.00%> (-2.56%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
provisioner/echo/serve.go56.80% <0.00%> (ø)
site/src/components/UserDropdown/UsersDropdown.tsx96.15% <0.00%> (ø)
site/src/testHelpers/index.tsx
site/src/api/index.ts
site/src/api/api.ts70.00% <0.00%> (ø)
... and7 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatebe3bc5c...49fa840. Read thecomment docs.

@Kira-PilotKira-Pilot merged commit2569787 intomainMay 11, 2022
@Kira-PilotKira-Pilot deleted the add-eslint-to-recommendations/kira-pilot branchMay 11, 2022 23:01
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ESLint to recommended extensions list
2 participants
@Kira-Pilot@greyscaled
[8]ページ先頭
©2009-2025 Movatter.jp