Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(site): edit organization member roles#13977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 13 commits intomainfromimprove-org-members-table
Jul 24, 2024

Conversation

aslilac
Copy link
Member

Screenshot 2024-07-22 at 3 46 57 PM

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code looks good 👍 but I'm missing the tests.

@BrunoQuaresma

This comment was marked as resolved.

@aslilac
Copy link
MemberAuthor

aslilac commentedJul 23, 2024
edited
Loading

Fixed up 1, 2, and 4. As for 3,

We should provide a description for each role in the options.

This would require a fair bit of backend work. Especially for custom roles, I think letting admins enter a role description and surfacing that on the frontend is a good idea, but non-trivial to add.

BrunoQuaresma reacted with thumbs up emoji

@aslilacaslilac merged commit38b5738 intomainJul 24, 2024
33 checks passed
@aslilacaslilac deleted the improve-org-members-table branchJuly 24, 2024 17:36
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp