Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: generate rbac resource types to typescript#13975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 4 commits intomainfromstevenmasley/ts_rbac_types
Jul 23, 2024

Conversation

Emyrk
Copy link
Member

The existing typesGenerated.ts cannot support this as the generator only inspects the types, not the values. So traversing the value AST would have to be added. The rbac gen is already used for the sdk, this extends it to the typescript

The existing typesGenerated.ts cannot support this as the generatoronly inspects the types, not the values. So traversing the value ASTwould have to be added. The rbac gen is already used for the sdk,this extends it to the typescript
@EmyrkEmyrk requested a review fromf0sselJuly 23, 2024 14:51
Copy link
Contributor

@f0sself0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Output looks good. Can you explain the need for exposing this to the frontend?

@Emyrk
Copy link
MemberAuthor

Output looks good. Can you explain the need for exposing this to the frontend?

For the custom roles page, there is going to be a checkbox style set of permissions. The checkbox list should be sourced frompolicy.go the same way our cli currently is.

Screenshot from 2024-07-23 10-07-28

Rather than manually creating said list.

@EmyrkEmyrk merged commitecc356f intomainJul 23, 2024
32 checks passed
@EmyrkEmyrk deleted the stevenmasley/ts_rbac_types branchJuly 23, 2024 15:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@f0sself0sself0ssel approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@f0ssel

[8]ページ先頭

©2009-2025 Movatter.jp