Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: renaming index files#1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Kira-Pilot merged 1 commit intomainfromrename-index-files/kira-pilot
May 11, 2022
Merged

Conversation

Kira-Pilot
Copy link
Member

@Kira-PilotKira-Pilot commentedMay 11, 2022•
edited
Loading

Renamingindex files to something (a bit) more specific.Resolves#1211.
I actually couldn't find that many instances - only the two mentioned in the ticket. I figured we didn't want to rename barrel files or our index page but if you see something, say something!

greyscaled reacted with hooray emoji
@Kira-PilotKira-Pilot requested review frompresleyp anda team ascode ownersMay 11, 2022 20:25
@codecov
Copy link

codecovbot commentedMay 11, 2022•
edited
Loading

Codecov Report

Merging#1397 (6e1c7db) intomain (982769f) willincrease coverage by0.15%.
The diff coverage is75.00%.

@@            Coverage Diff             @@##             main    #1397      +/-   ##==========================================+ Coverage   66.90%   67.06%   +0.15%==========================================  Files         288      287       -1       Lines       18857    18850       -7       Branches      241      241              ==========================================+ Hits        12616    12641      +25+ Misses       4949     4924      -25+ Partials     1292     1285       -7
FlagCoverage Δ
unittest-go-macos-latest54.11% <ø> (+0.08%)⬆️
unittest-go-postgres-65.51% <ø> (+0.14%)⬆️
unittest-go-ubuntu-latest56.45% <ø> (-0.06%)⬇️
unittest-go-windows-202252.37% <ø> (+<0.01%)⬆️
unittest-js74.24% <75.00%> (ø)
Impacted FilesCoverage Δ
site/src/api/api.ts70.00% <ø> (ø)
site/src/pages/CliAuthPage/CliAuthPage.tsx0.00% <0.00%> (ø)
...anizationPage/TemplatePage/CreateWorkspacePage.tsx0.00% <0.00%> (ø)
site/src/testHelpers/renderHelpers.tsx100.00% <ø> (ø)
site/src/xServices/auth/authXService.ts82.60% <100.00%> (ø)
site/src/xServices/buildInfo/buildInfoXService.ts71.42% <100.00%> (ø)
site/src/xServices/roles/siteRolesXService.ts80.00% <100.00%> (ø)
site/src/xServices/terminal/terminalXService.ts68.42% <100.00%> (ø)
site/src/xServices/users/usersXService.ts72.91% <100.00%> (ø)
site/src/xServices/workspace/workspaceXService.ts59.09% <100.00%> (ø)
... and13 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update982769f...6e1c7db. Read thecomment docs.

Copy link
Contributor

@greyscaledgreyscaled left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great!

One suggestion is toLink your PR to the issue so that it automatically closes when it merges.

There's 2 standard ways to do this, I suggest both:

  1. Adding a body to your commit message
chore: renaming index filesresolves: #1211
  1. Adding the same in your PR description

I think we forgot to mention this anywhere in our onboarding docs, especially because we used to use an external tracker where we got this for free through the branch name.

Hope that helps!

@Kira-Pilot
Copy link
MemberAuthor

One suggestion is toLink your PR to the issue so that it automatically closes when it merges.

Gotcha! Adjusted the description and will do going forward - thanks for the link.

@Kira-PilotKira-Pilot merged commitf93804a intomainMay 11, 2022
@Kira-PilotKira-Pilot deleted the rename-index-files/kira-pilot branchMay 11, 2022 21:02
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

@presleyppresleypAwaiting requested review from presleyp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename remaining index files
2 participants
@Kira-Pilot@greyscaled
[8]ページ先頭
©2009-2025 Movatter.jp