- Notifications
You must be signed in to change notification settings - Fork1k
feat: add organization details to audit log response#13961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Not all audit entries have organization IDs, so this will allow us totest those cases.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
6f4b6bf
to8740626
CompareThis replaces the old ID. This is a breaking change but organizationswere not being used before.
8740626
to2b25f46
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There is another test called "organizations" so this distinguishes thatthis is checking the response itself contains this field. Rename theuser test to match.
ebaa981
to755d189
CompareBut mark it as deprecated.
755d189
tode75d4f
Compare
Uh oh!
There was an error while loading.Please reload this page.
This is so the frontend will be able to display the organization name in the audit log row.
I added
MinimalOrganization
to mirrorMinimalUser
. It will be omitted if there was no organization, which I felt made more sense in the frontend (rather than the uuid zero value), but I can change that back if we want.This new object replaces the old organization ID property on audit logs. Technically a breaking change? But we were not using it and I doubt anyone else was.
This is explained in the commit message, but
params.OrganizationID == uuid.Nil
was removed from the test audit log creation so I could test audit logs without an org.Part 1 of#13913