Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add organization details to audit log response#13961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 6 commits intomainfromasher/audit-log-orgs
Jul 22, 2024

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedJul 19, 2024
edited
Loading

This is so the frontend will be able to display the organization name in the audit log row.

I addedMinimalOrganization to mirrorMinimalUser. It will be omitted if there was no organization, which I felt made more sense in the frontend (rather than the uuid zero value), but I can change that back if we want.

This new object replaces the old organization ID property on audit logs. Technically a breaking change? But we were not using it and I doubt anyone else was.

This is explained in the commit message, butparams.OrganizationID == uuid.Nil was removed from the test audit log creation so I could test audit logs without an org.

Part 1 of#13913

Not all audit entries have organization IDs, so this will allow us totest those cases.
@code-ashercode-asher changed the titleAdd organization details to audit logsfeat: add organization details to audit logsJul 19, 2024
@code-ashercode-asherforce-pushed theasher/audit-log-orgs branch 3 times, most recently from6f4b6bf to8740626CompareJuly 19, 2024 23:54
This replaces the old ID.  This is a breaking change but organizationswere not being used before.
There is another test called "organizations" so this distinguishes thatthis is checking the response itself contains this field.  Rename theuser test to match.
But mark it as deprecated.
@code-ashercode-asher changed the titlefeat: add organization details to audit logsfeat: add organization details to audit log responseJul 22, 2024
@code-ashercode-asher merged commita8e6e89 intomainJul 22, 2024
@code-ashercode-asher deleted the asher/audit-log-orgs branchJuly 22, 2024 21:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@code-ashercode-asher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@code-asher@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp