Codecov Report

Merging#1394 (f8f6125) intomain (e8e6d3c) willincrease coverage by0.01%.
The diff coverage is72.05%.

@@            Coverage Diff             @@##             main    #1394      +/-   ##==========================================+ Coverage   67.01%   67.03%   +0.01%==========================================  Files         287      288       +1       Lines       18850    19083     +233       Branches      241      241              ==========================================+ Hits        12633    12792     +159- Misses       4931     4985      +54- Partials     1286     1306      +20

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee8e6d3c...f8f6125. Read thecomment docs.

I don't have time to properly review right now but I wanted to mention that I think more fields onCreateWorkspaceBuildRequest are optional than what shows intypesGenerated - if I understand right, everything buttransition. Not sure if this is the only case missing optionality. If that's easy to fix it would be nice to have it right before we start relying more on generated types.

Looks like you are right. Fortunately it is pretty easy, we just need to addomitempty and then runmake gen (ormake site/src/api/typesGenerated.ts); I will do that now forCreateWorkspaceBuildRequest.

I am not sure what the best way to tackle this is (not sure if I have to read the code to find what is optional or if everything without arequired tag can be safely considered optional) but I think I will at the very least check all the*Request interfaces to make sure they have the right optionalities.

nice! seems likemake gen is run on save - is that right?

All right the request interfaces are looking good.UpdateWorkspaceAutostartRequest andUpdateWorkspaceAutostopRequest have aschedule property that could technically be made optional but I left them as-is so you have to explicitly set an empty string to disable the schedule. Not sure if that is the right call (maybe disabling should be an entirely separate endpoint but that seems like a separate discussion).

@Kira-Pilot I seemake gen running on saves to .sql files (if using VS Code) but not other changes so if we make changes to interfaces or types (or if using a different editor) I think we have to run it manually (entirely possible I missed something though).

@code-asher yay thanks! The empty string for schedule makes sense to me.

@Kira-Pilot we run it manually. On save is a bit excessive since it does takesome time. But CI will have a failing step if you changed something andmake gen needs to be run again. So I usually let CI tell me if I need to run it 🤷