- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: patch 2.13.1#13927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
chore: patch 2.13.1#13927
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
stirby commentedJul 17, 2024
- fix: let workspace pages download partial logs for unhealthy workspaces #13761
- fix(site): enable dormant workspace to be deleted #13850
…es (#13761)* fix: get basic fix in for preventing download logs from blowing up UI* fix: make sure blob units can't go out of bounds* fix: make sure timeout is cleared on component unmount* fix: reduce risk of shared cache state breaking useAgentLogs* fix: allow partial downloading of logs* fix: make sure useMemo cache is used properly* wip: commit current progress on updated logs functionality* docs: rewrite comment for clarity* refactor: clean up current code* fix: update styles for unavailable logs* fix: resolve linter violations* fix: update type signature of getErrorDetail* fix: revert log/enabled logic for useAgentLogs* fix: remove memoization from DownloadLogsDialog* fix: update name of timeout state* refactor: make log web sockets logic more clear* docs: reword comment for clarity* fix: commit current style update progress* fix: finish style updates(cherry picked from commit940afa1)
(cherry picked from commit01b30ea)
(cherry picked from commit80cbffe)
buenos-nachos approved these changesJul 18, 2024
Contributor
buenos-nachos left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Didn't realize that we were getting rid of organization ID stuff to support multiple organizations, but it makes sense.
Everything looks good here.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.