Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(docs): add missing author to support bundle guide#13918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromguide-missing-author
Jul 22, 2024

Conversation

stirby
Copy link
Collaborator

Added author info and date to the support bundle guide.

@johnstcn, leaving you as the sole reviewer - not sure if you'd like to intentionally stay anonymous.

Original:#12931

@stirbystirby added docsArea: coder.com/docs chore labelsJul 16, 2024
@stirbystirby requested a review fromjohnstcnJuly 16, 2024 22:33
@stirbystirby self-assigned thisJul 16, 2024
@@ -1,5 +1,14 @@
# Generate and upload a Support Bundle to Coder Support


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should probably not add html tags in the markdown and add this information in the markdown header metadata.
Our docs engine then should parse it.

See the modules and templates readme to see what I am talking about.

---
display_name:Docker Containers
description:Provision Docker containers as Coder workspaces
icon:../../../site/static/icon/docker.png
maintainer_github:coder
verified:true
tags:[docker, container]
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can also do it as part of docs refactor work.

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Open to adding this with the restructure. I initially hacked the author info together because we rushed guides.

Good call.

matifali reacted with thumbs up emoji
Signed-off-by: Cian Johnston <cian@coder.com>
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fine for now, we can migrate to parsing markdown header content in a separate PR.

@johnstcnjohnstcn merged commit3c2c5ab intomainJul 22, 2024
27 checks passed
@johnstcnjohnstcn deleted the guide-missing-author branchJuly 22, 2024 08:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali left review comments

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@stirbystirby

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@stirby@johnstcn@matifali

[8]ページ先頭

©2009-2025 Movatter.jp