Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: notify owner about failed autobuild#13891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 13 commits intomainfrom7-autobuild-failure
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fix: build reason
  • Loading branch information
@mtojek
mtojek committedJul 15, 2024
commite6a5aef55cbd2a85d32b6593e5752f9984cb3e7c
2 changes: 1 addition & 1 deletioncoderd/provisionerdserver/provisionerdserver.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1100,7 +1100,7 @@ func (s *server) notifyWorkspaceBuildFailed(ctx context.Context, workspace datab
if build.Reason.Valid() && build.Reason == database.BuildReasonInitiator {
return // failed workspace build initiated by a user should not notify
}
reason ="initiated by autobuild"
reason =string(build.Reason)
initiator := "autobuild"

if _, err := s.NotificationEnqueuer.Enqueue(ctx, workspace.OwnerID, notifications.WorkspaceAutobuildFailed,
Expand Down
6 changes: 2 additions & 4 deletionscoderd/provisionerdserver/provisionerdserver_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1702,9 +1702,8 @@ func TestNotifications(t *testing.T) {
tests := []struct {
name string

buildReason database.BuildReason
shouldNotify bool
shouldDeleteWorkspace bool
buildReason database.BuildReason
shouldNotify bool
}{
{
name: "initiated by owner",
Expand DownExpand Up@@ -1793,7 +1792,6 @@ func TestNotifications(t *testing.T) {

workspace, err = db.GetWorkspaceByID(ctx, workspace.ID)
require.NoError(t, err)
require.Equal(t, tc.shouldDeleteWorkspace, workspace.Deleted)

if tc.shouldNotify {
// Validate that the notification was sent and contained the expected values.
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp