Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: create and modify organization groups#13887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 14 commits intomainfromorg-groups
Jul 22, 2024
Merged

feat: create and modify organization groups#13887

aslilac merged 14 commits intomainfromorg-groups
Jul 22, 2024

Conversation

@aslilac
Copy link
Member

@aslilacaslilac commentedJul 12, 2024•
edited
Loading

Screenshot 2024-07-18 at 12 12 57 PMScreenshot 2024-07-18 at 12 13 08 PMScreenshot 2024-07-18 at 12 13 17 PM

Allow creating groups, managing members, deleting groups, changing settings. All the usual groups stuff, just now manageable in multi-org configurations!

@aslilacaslilac changed the title🫣feat: create and modify organization groupsJul 17, 2024
@aslilacaslilac marked this pull request as ready for reviewJuly 18, 2024 18:11
@aslilacaslilac requested review fromBrunoQuaresma andjaaydenh and removed request forBrunoQuaresmaJuly 18, 2024 18:11
jaaydenh

This comment was marked as resolved.

Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good! I'm missing tests for the interactive parts but I will leave it up to you to decide when to add them.

@BrunoQuaresma
Copy link
Contributor

  1. When accessing the groups settings, I see the error "Route not found". We probably should omit this error for non-enterprise users.
Screenshot 2024-07-19 at 10 26 27
  1. When I try to add a user that is outside of the organization, I get a non-user-friendly error message. In this case, we can improve the error message and only display valid user options in the autocomplete.
Screenshot 2024-07-19 at 10 32 52
  1. Sometimes I felt "lost" in the groups settings navigation. The user can navigate into groups, select a group, and navigate to other sub-pages like "new group" and "group settings". For nested pages like these, I think is nice to have a breadcrumb somewhere on the page, maybe on the page header on top of the title.

@aslilac
Copy link
MemberAuthor

only display valid user options in the autocomplete

This is a similar problem to not showing users that are already added. We'd need to do a major refactor of theUserAutocomplete component to support these features. It would be really nice polish, but is out of scope for this PR.

@aslilac
Copy link
MemberAuthor

I think is nice to have a breadcrumb somewhere on the page, maybe on the page header on top of the title.

This could be a nice bit of polish too, but will also have to wait until later.

@aslilacaslilac merged commit0a71c34 intomainJul 22, 2024
@aslilacaslilac deleted the org-groups branchJuly 22, 2024 15:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jaaydenhjaaydenhjaaydenh left review comments

+1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aslilacaslilac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aslilac@BrunoQuaresma@jaaydenh
[8]ページ先頭
©2009-2025 Movatter.jp