- Notifications
You must be signed in to change notification settings - Fork927
chore: provisioner acquirer to respect organization ID of jobs#13874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Prior to this the wrong provisioner was awakened on any new jobposting.
Emyrk commentedJul 11, 2024
| @@ -1829,3 +1829,51 @@ func TestTemplateAccess(t *testing.T) { | |||
| } | |||
| }) | |||
| } | |||
| func TestMultipleOrganizationTemplates(t *testing.T) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test would always fail prior to this change.
deansheather approved these changesJul 11, 2024
687d953 intomain 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The domain check to choose what provisioned to give clearance to is defined by the
containsfunction. This omitted the organization ID check, so the wrong provisioner could be given clearance, and the job would not be grabbed.When organization ID was added to the jobs, it was only added to the
domainKeyfunction. This now includes it in both places.A 30s update interval would eventually make it work.
What this does
The pubsub message when a job is posted now chooses the right provisionerd to awaken when multiple organizations exist.