Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: userw.WriteHeader to write responses without bodies#13870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 3 commits intomainfromno-ignored-body
Jul 11, 2024

Conversation

aslilac
Copy link
Member

the body gets ignored anyway, so why bother allocating/serializing anything?

@Emyrk
Copy link
Member

We also do this tracing span end too:

_,span:=tracing.StartSpan(ctx)
deferspan.End()

We'd be losing that.

@aslilac
Copy link
MemberAuthor

yes, but all that span measures is time to encode the body and write it to the wire. I guess we could add a new function that just writes the head and tracks that with a span?

@Emyrk
Copy link
Member

Emyrk commentedJul 11, 2024•
edited
Loading

I misread what the span did, this is not a big deal 👍

@aslilacaslilac merged commitde2585b intomainJul 11, 2024
29 checks passed
@aslilacaslilac deleted the no-ignored-body branchJuly 11, 2024 19:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 11, 2024
Comment on lines -454 to +428
| Status | Meaning| Description | Schema |
| ------ | ------------------------------------------------------- |----------- | ---------------------------------------- |
|200 | [OK](https://tools.ietf.org/html/rfc7231#section-6.3.1) |OK| [codersdk.User](schemas.md#codersdkuser) |
| Status | Meaning| Description | Schema |
| ------ | --------------------------------------------------------------- | ----------- |------ |
|204 | [No Content](https://tools.ietf.org/html/rfc7231#section-6.3.5) |No Content | |
Copy link
Member

@EmyrkEmyrkAug 5, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was a breaking change that we missed.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp