NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

chore: return organization's display name and icon in templates#13858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Emyrk merged 9 commits intomainfromstevenmasley/organization_display_name_with_template

Jul 10, 2024

Merged

chore: return organization's display name and icon in templates#13858

Emyrk merged 9 commits intomainfromstevenmasley/organization_display_name_with_template

Jul 10, 2024

Conversation

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it possible that the created_by user is not visible by the caller of this? I'm thinking the case where someone is removed from an org after creating a template.

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is, but we decided awhile back that if you can read the template, you should also see who created it. So grantingread permission on the template gives some implicit permission to reading the user's name + organization information.