- Notifications
You must be signed in to change notification settings - Fork923
chore: remove references to restarting/stopping in update workspace language#13852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The terraform apply will just apply the start state.
| confirmText="Update" | ||
| description={ | ||
| <Stack> | ||
| <p> | ||
| Restarting your workspace will stop all running processes and{" "} | ||
| Updating your workspace will stop all running processes and{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Updatingyourworkspacewillstopallrunningprocessesand{" "} | |
| Updatingyourworkspacewill{" "} |
stop all running processes is kind of misleading, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are right. I am having some trouble trying to find the difference between our phrasing of "updating" vs the actual terraform actions 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks!
Also updated the batch update wording. Just saw that |
f927204 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The terraform apply will just apply the start state. The differences should be detected by terraform, and the workspace will be updated.
The confusion is that we do have a UI and a cli
coder restartthat does issue astop, starttransition. Updatedoes not do this.