NotificationsYou must be signed in to change notification settings
Fork926
Star10.1k

chore: update pnpm to v9#13843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 2 commits intomainfromcolin/update-pnpm

Jul 10, 2024

Merged

chore: update pnpm to v9#13843

coadler merged 2 commits intomainfromcolin/update-pnpm

Jul 10, 2024

Conversation

Copy link

Contributor

coadler commentedJul 9, 2024•
edited
Loading

Also updatesflake.nix to only use one version of nixpkgs and flake-utils.

cc@kylecarbs for flake stuffs

chore: update pnpm to v9

6911dc1

coadler requested a review fromkylecarbs

July 9, 2024 06:06

coadler self-assigned this

Jul 9, 2024

coadler requested review fromaslilac andmatifali

July 9, 2024 06:11

matifali reviewed

Jul 9, 2024

View reviewed changes

Copy link

Member

matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

golangci-lint versions are mismatched somake lint does not pass in local but passes in CI.

version inCI and dogfood Dockerfile: 1.55.2
version in nix:

golangci-lint versiongolangci-lint has version 1.59.1 built with go1.22.5 from v1.59.1 on 19700101-00:00:00atif@CTAR-ATIF-PC:~/github/coder/coder$which golangci-lint/nix/store/fx4p42sdx70hzpzsl71r5zwh8az0p74a-golangci-lint-1.59.1/bin/golangci-lint

Copy link

ContributorAuthor

coadler commentedJul 9, 2024

golangci-lint versions are mismatched somake lint does not pass in local but passes in CI.
version inCI and dogfood Dockerfile: 1.55.2 version in nix:
golangci-lint versiongolangci-lint has version 1.59.1 built with go1.22.5 from v1.59.1 on 19700101-00:00:00atif@CTAR-ATIF-PC:~/github/coder/coder$ which golangci-lint/nix/store/fx4p42sdx70hzpzsl71r5zwh8az0p74a-golangci-lint-1.59.1/bin/golangci-lint

Ok wow this returns a gigantic number of errors. I'll just pin golangci for now in nix.

Copy link

Member

matifali commentedJul 9, 2024

Same forshfmt
CI: 3.7.0
nix: 3.8.0
Dogfood:latest i.e 3.8.0

Did not check for other tool mismatches.

We need to devise a better way to sync development and CI. A workaround is to use theDockerfile.nix but it can be further optimized and fixed to run frontend tests.