Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add "needs grooming" label to new issues#1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 1 commit intomainfrombpmct/issue-template-grooming
May 11, 2022

Conversation

bpmct
Copy link
Member

No description provided.

@bpmctbpmct requested review frommisskniss andjsjoeioMay 11, 2022 13:00
@bpmctbpmct self-assigned thisMay 11, 2022
@codecov
Copy link

codecovbot commentedMay 11, 2022•
edited
Loading

Codecov Report

Merging#1384 (38220fd) intomain (9d94f4f) willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##             main    #1384   +/-   ##=======================================  Coverage   66.93%   66.93%           =======================================  Files         288      288             Lines       18856    18856             Branches      241      241           =======================================  Hits        12622    12622+ Misses       4944     4942    -2- Partials     1290     1292    +2
FlagCoverage Δ
unittest-go-macos-latest53.96% <ø> (-0.12%)⬇️
unittest-go-postgres-65.42% <ø> (+<0.01%)⬆️
unittest-go-ubuntu-latest56.41% <ø> (+0.02%)⬆️
unittest-go-windows-202252.41% <ø> (+0.03%)⬆️
unittest-js74.24% <ø> (ø)
Impacted FilesCoverage Δ
provisionersdk/serve.go35.13% <0.00%> (-8.11%)⬇️
peerbroker/dial.go77.04% <0.00%> (-6.56%)⬇️
coderd/turnconn/turnconn.go81.91% <0.00%> (-3.20%)⬇️
codersdk/workspaceagents.go51.52% <0.00%> (-1.36%)⬇️
agent/agent.go65.90% <0.00%> (-1.24%)⬇️
provisionerd/provisionerd.go75.76% <0.00%> (-0.41%)⬇️
coderd/workspaceagents.go57.90% <0.00%> (+1.86%)⬆️
peer/conn.go80.34% <0.00%> (+1.96%)⬆️
cli/cliui/provisionerjob.go78.57% <0.00%> (+2.14%)⬆️
peerbroker/listen.go87.39% <0.00%> (+3.36%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update9d94f4f...38220fd. Read thecomment docs.

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

An external contributor won't know how to take action on this. Could we assume issues without labels need grooming? That seems like a way to reduce our labels, and not confuse contributors.

Thoughts@tjcran@misskniss ?

@jsjoeio
Copy link
Contributor

An external contributor won't know how to take action on this. Could we assume issues without labels need grooming?

I don't think we need to worry about that. There is no expectation that they would take action on that. They wouldn't be able to regardless.

We use the "triage" label on code-server and it serves the same purpose.

Copy link
Contributor

@jsjoeiojsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this makes sense! Plus we can easily change this if needed later.

@bpmct
Copy link
MemberAuthor

bpmct commentedMay 11, 2022•
edited
Loading

I see - will merge once@misskniss takes a look

@kylecarbs
Copy link
Member

Ahh fair enough@jsjoeio !

jsjoeio reacted with thumbs up emoji

@bpmctbpmct merged commit537897c intomainMay 11, 2022
@bpmctbpmct deleted the bpmct/issue-template-grooming branchMay 11, 2022 19:35
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs left review comments

@jsjoeiojsjoeiojsjoeio approved these changes

@missknissmissknissAwaiting requested review from misskniss

Assignees

@bpmctbpmct

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

4 participants
@bpmct@jsjoeio@kylecarbs@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp