- Notifications
You must be signed in to change notification settings - Fork928
chore: refactorAgentHasNotConnectedSinceWeek_LogsExpired#13802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // when | ||
| closer := dbpurge.New(ctx, logger, db) | ||
| defer closer.Close() | ||
| // then | ||
| require.Eventually(t, func() bool { | ||
| agentLogs, err := db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{ | ||
| assert.Eventually(t, func() bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| assert.Eventually(t,func()bool { | |
| require.Eventually(t,func()bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
require.Eventually will fail withCondition never met. I want to run the follow-up assertion afterward to see what is on the list.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
10aa32c intomainUh oh!
There was an error while loading.Please reload this page.
Related:#13801
This PR refactors
AgentHasNotConnectedSinceWeek_LogsExpiredto get more debug insights into this specific unit test.