NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

chore: group dependencies#13798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

matifali merged 4 commits intomainfrommatifali/npm-dependabot-groups

Jul 8, 2024

Merged

chore: group dependencies#13798

matifali merged 4 commits intomainfrommatifali/npm-dependabot-groups

Jul 8, 2024

Conversation

Copy link

Member

matifali commentedJul 6, 2024•
edited
Loading

This should help reduce dependabot noise. Probably grouping can be further improved.

chore: group frontend dependencies

4e25f8d

matifali self-assigned this

Jul 6, 2024

matifali added2 commits

July 6, 2024 12:32

refine

9d78199

elaborate

d647e81

matifali requested a review fromaslilac

July 6, 2024 12:37

matifali commented

Jul 6, 2024

View reviewed changes

.github/dependabot.yamlShow resolvedHide resolved

matifali changed the title~~chore: group frontend dependencies~~chore: group dependencies

Jul 8, 2024

group golang.org/x/ dependencies

8c821ac

matifali requested a review fromcoadler

July 8, 2024 12:08

Copy link

Member

aslilac commentedJul 8, 2024

I know we had this before, so I'm curious why it was removed. Was it causing any issues?

Copy link

MemberAuthor

matifali commentedJul 8, 2024•
edited
Loading

@aslilac we did had them in#8453 but were still not happy with amount of PRs dependabot was creating. So we created a single large group of everything in#10870. This made the PRs unmergeable and was creating PRs with 67 dependencies update in a single PR.
So again adding some very carefully chosen groups should provide an acceptable middle ground.