- Notifications
You must be signed in to change notification settings - Fork1k
feat: add killswitch for notifications#13794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
22 commits Select commitHold shift + click to select a range
735d0ef
feat: add killswitch for notifications
mtojekb6338e5
revert
mtojek16c8950
migrate down
mtojekedfff5e
304
mtojek89e1396
Notifications settings
mtojekab8a6c7
debug message
mtojek2522366
return true
mtojek7dfbd29
remove WillUsePostgres
mtojekd7f470d
Merge branch 'main' into 4-pause-1
mtojek6abf39f
fix client 304
mtojek341485f
createSampleUser
mtojekc90ff21
sdkError
mtojekda6775f
remove test for not modified
mtojek9d430bb
swagger update
mtojeka55fc8a
bring back Settings not modified
mtojekaf36afb
enable WillUsePostgres in TestWebhookDispatch
mtojek7e8ad09
refactor Settings not modified
mtojekce1a9e9
refactored TestNotifierPaused
mtojekdbf6a40
bug: RLock RUnlock
mtojekc2e181c
Danny's review
mtojekfa0f381
Merge branch 'main' into 4-pause-1
mtojek83978e7
fix
mtojekFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
bring back Settings not modified
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita55fc8a8ad55e6d5c66f0f84784c633a814cb3da
There are no files selected for viewing
18 changes: 18 additions & 0 deletionscoderd/notifications_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -60,4 +60,22 @@ func TestUpdateNotificationsSettings(t *testing.T) { | ||
require.NoError(t, err) | ||
require.Equal(t, expected, actual) | ||
}) | ||
t.Run("Settings not modified", func(t *testing.T) { | ||
t.Parallel() | ||
client := coderdtest.New(t, nil) | ||
_ = coderdtest.CreateFirstUser(t, client) | ||
ctx := testutil.Context(t, testutil.WaitShort) | ||
// given | ||
expected := codersdk.NotificationsSettings{ | ||
NotifierPaused: false, | ||
} | ||
// then | ||
err := client.PutNotificationsSettings(ctx, expected) | ||
require.NoError(t, err) | ||
dannykopping marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
}) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.