Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add killswitch for notifications#13794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 22 commits intomainfrom4-pause-1
Jul 10, 2024
Merged

feat: add killswitch for notifications#13794

mtojek merged 22 commits intomainfrom4-pause-1
Jul 10, 2024

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedJul 5, 2024•
edited
Loading

Related:coder/internal#4
Blocked:#13537

This PR introduces API endpoints to pause/unpause the notifier. The setting is stored in the database. In the follow up I will add CLI support to control the setting.

@mtojekmtojek self-assigned thisJul 5, 2024
@mtojekmtojek changed the base branch frommain todk/notificationsJuly 5, 2024 14:20
@mtojekmtojek changed the base branch fromdk/notifications tomainJuly 5, 2024 14:20
@mtojekmtojek changed the base branch frommain todk/system-notifications-libJuly 8, 2024 07:52
Base automatically changed fromdk/system-notifications-lib tomainJuly 8, 2024 13:38
@mtojekmtojek marked this pull request as ready for reviewJuly 9, 2024 12:12
@mtojekmtojek requested a review fromdannykoppingJuly 9, 2024 12:20
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall looks good! Mostly small comments and a few nits.

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Last couple nits, none of them blocking

@mtojek
Copy link
MemberAuthor

@dannykopping It looks like there is some flakiness aroundbulkUpdate?https://github.com/coder/coder/actions/runs/9874898408/job/27270328403?pr=13794. Not sure what is the root cause of messages not being dequeued.

    t.go:99: 2024-07-10 13:15:17.886 [debu]  manager.notifier: dispatch completed  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=1    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: check if notifier is paused  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: attempting to dequeue messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: dequeued messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=1    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: message dispatch succeeded  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  msg_id=4681beed-a763-41a1-badc-b205bfe03ed8  method=smtp    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: dispatch completed  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=1    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: check if notifier is paused  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: attempting to dequeue messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: dequeued messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=1    t.go:99: 2024-07-10 13:15:17.887 [debu]  manager.notifier: message dispatch succeeded  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  msg_id=4681beed-a763-41a1-badc-b205bfe03ed8  method=smtp    t.go:99: 2024-07-10 13:15:17.906 [debu]  enqueuer: enqueued notification  msg_id=74f1fd65-d602-42e4-87c9-a83a91abba9f    t.go:99: 2024-07-10 13:15:19.881 [debu]  manager: bulk update completed  type=update_sent  updated=-1    t.go:99: 2024-07-10 13:15:19.881 [debu]  manager.notifier: dispatch completed  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=1    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: check if notifier is paused  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: attempting to dequeue messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: dequeued messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=2    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: message dispatch succeeded  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  msg_id=74f1fd65-d602-42e4-87c9-a83a91abba9f  method=smtp    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: message dispatch succeeded  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  msg_id=4681beed-a763-41a1-badc-b205bfe03ed8  method=smtp    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: dispatch completed  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=2    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: check if notifier is paused  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: attempting to dequeue messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26    t.go:99: 2024-07-10 13:15:19.882 [debu]  manager.notifier: dequeued messages  notifier_id=97bfe604-a0be-4caf-b276-db37b98e3a26  count=2
dannykopping reacted with eyes emoji

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@mtojekmtojek merged commitbf392ff intomainJul 10, 2024
30 of 32 checks passed
@mtojekmtojek deleted the 4-pause-1 branchJuly 10, 2024 14:15
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mtojek@dannykopping
[8]ページ先頭
©2009-2025 Movatter.jp