Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: macOS backspace processing#1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/1226-revert-long-lines-fix
May 10, 2022

Conversation

spikecurtis
Copy link
Contributor

Revert "fix: Remove line length limit on MacOS for input prompts (#839)"

This reverts commitccba2ba from#839 but which introduced bug#1226

Fixes#1226

Revert "fix: Remove line length limit on MacOS for input prompts (#839)"This reverts commitccba2ba.
@spikecurtisspikecurtis self-assigned thisMay 10, 2022
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@codecov
Copy link

codecovbot commentedMay 10, 2022•
edited
Loading

Codecov Report

Merging#1379 (b3f1899) intomain (f816bbe) willdecrease coverage by0.00%.
The diff coverage isn/a.

@@            Coverage Diff             @@##             main    #1379      +/-   ##==========================================- Coverage   66.94%   66.93%   -0.01%==========================================  Files         290      288       -2       Lines       18885    18856      -29       Branches      241      241              ==========================================- Hits        12642    12621      -21+ Misses       4956     4943      -13- Partials     1287     1292       +5
FlagCoverage Δ
unittest-go-macos-latest54.01% <ø> (+0.06%)⬆️
unittest-go-postgres-65.38% <ø> (-0.07%)⬇️
unittest-go-ubuntu-latest56.41% <ø> (-0.01%)⬇️
unittest-go-windows-202252.38% <ø> (+<0.01%)⬆️
unittest-js74.24% <ø> (ø)
Impacted FilesCoverage Δ
cli/cliui/prompt.go76.47% <ø> (+6.57%)⬆️
codersdk/provisionerdaemons.go61.97% <0.00%> (-5.64%)⬇️
peerbroker/listen.go84.03% <0.00%> (-3.37%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
coderd/workspaceagents.go56.04% <0.00%> (-1.87%)⬇️
provisionerd/provisionerd.go76.30% <0.00%> (-1.34%)⬇️
peer/conn.go80.34% <0.00%> (ø)
agent/agent.go67.14% <0.00%> (ø)
coderd/httpapi/httpapi.go77.50% <0.00%> (+6.25%)⬆️
provisionersdk/serve.go43.24% <0.00%> (+8.10%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef816bbe...b3f1899. Read thecomment docs.

@spikecurtisspikecurtis merged commit9d94f4f intomainMay 10, 2022
@spikecurtisspikecurtis deleted the spike/1226-revert-long-lines-fix branchMay 10, 2022 22:20
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Revert "fix: Remove line length limit on MacOS for input prompts (#839)"This reverts commitccba2ba.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Bug: can't use Backspace in "Specify a name for your workspace"
3 participants
@spikecurtis@kylecarbs@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp