Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: implement multi-org template gallery#13784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 25 commits intomainfrommulti-org-template-gallery
Jul 19, 2024

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedJul 3, 2024•
edited
Loading

Resolves#13775

  • Setup new /templates route to retrieve templates for all organizations for a user
  • Create new template gallery page calledMultiOrgTemplatesPageView using a grid layout
  • Create Storybook component forMultiOrgTemplatesPageView
  • Filter templates by organization-id
  • Render multi-org template gallery page if multi-organization experiment is enabled
  • Create component for TemplateCard in template gallery grid
  • Create storybook component forTemplateCard
  • Display organization count to the right of each organization in the organization labels list
  • Highlight template card on mouseover, onClick should link to template page
  • Hide organization filter if the user has templates for only 1 organization
Screenshot 2024-07-16 at 8 11 56 PM

@jaaydenhjaaydenh self-assigned thisJul 3, 2024
@jaaydenhjaaydenh changed the titleMulti org template galleryfeat: multi-org template galleryJul 3, 2024
@jaaydenhjaaydenh changed the titlefeat: multi-org template galleryfeat: implement multi-org template galleryJul 3, 2024
@jaaydenhjaaydenhforce-pushed themulti-org-template-gallery branch 3 times, most recently fromfa872e0 to63827efCompareJuly 11, 2024 02:29
@jaaydenhjaaydenh requested a review fromaslilacJuly 11, 2024 15:20
@jaaydenhjaaydenh marked this pull request as ready for reviewJuly 11, 2024 15:20
@BrunoQuaresma
Copy link
Collaborator

I have a few design considerations. I believe we can avoid adding more components and create another view solely for filtering based on organizations. We could achieve this using pills as filters or by replicating what we have for workspaces.

Pills:

Pill Tabs

Replicating Workspaces:

Search

@jaaydenhjaaydenhforce-pushed themulti-org-template-gallery branch 2 times, most recently from89e54a4 tobd2bb03CompareJuly 15, 2024 16:35
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sorry for taking so long to review! 💀


export const TemplateCard: FC<TemplateCardProps> = ({
template,
...divProps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

super minor nit, I tend to call these sorts of capturesattrs, but there's definitely precedent for calling itwhateverProps too. maybe this is something we should consolidate on...

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was following the pattern in the files I was working on. In other code bases/the React docs, this is often called ...props as well. I think it depends if we want to call them based on what they are, "props" or how they are used, props on divs "divProps" or attributes on divs "attrs"

@jaaydenh
Copy link
ContributorAuthor

I have a few design considerations. I believe we can avoid adding more components and create another view solely for filtering based on organizations. We could achieve this using pills as filters or by replicating what we have for workspaces.

@aslilac Can you comment on the feedback from@BrunoQuaresma as you have more context around the design decisions?

@jaaydenhjaaydenh requested a review fromaslilacJuly 17, 2024 02:04
@jaaydenhjaaydenhforce-pushed themulti-org-template-gallery branch fromfc2e6f9 to801138aCompareJuly 17, 2024 14:51
@aslilac
Copy link
Member

@BrunoQuaresma the design is based off of the starter template gallery, and aims to bring some distinction between the appearance of workspace related pages and the appearance of the template related pages. investigating the pills idea sounds interesting, but we can mess with the design more after the experiment has shipped.

BrunoQuaresma reacted with thumbs up emoji

@jaaydenhjaaydenh merged commit554c4ab intomainJul 19, 2024
31 checks passed
@jaaydenhjaaydenh deleted the multi-org-template-gallery branchJuly 19, 2024 14:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma left review comments

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-org templates page
3 participants
@jaaydenh@BrunoQuaresma@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp