- Notifications
You must be signed in to change notification settings - Fork928
chore: update mui#13747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: update mui#13747
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Parkreiner commentedJul 2, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'll kick the tires a bit in about 30 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tried a lot of the pages and components that use MUI a lot, and didn't notice any problems. Think this is safe to merge
| css={{ | ||
| pointerEvents: canClick ? undefined : "none", | ||
| textDecoration: "none !important", | ||
| }} | ||
| onClick={async (event) => { | ||
| onClick={async (event: MouseEvent<HTMLElement>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tried seeing what would happen if I removed the type annotation, and man, MUI really is a disaster of megamorphic abstractions, huh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes, yes it is :^)
bfbf634 intomainUh oh!
There was an error while loading.Please reload this page.
Closes#13734
dependabot wants to update, but isn't smart enough to group these updates