Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: fix docs on deploying workspaces in additional namespaces#13724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 4 commits intomainfromfix-sa-docs
Jul 10, 2024

Conversation

ericpaulsen
Copy link
Member

our docs incorrectly point users to creating a new ServiceAccount and token for deploying workspaces in additional namespaces.

thecoder Service Account is already created as a part of the Helm install, so only a Role and RoleBinding are needed to properly give permissions.

let me know if i'm missing something here.

@ericpaulsenericpaulsen added the docsArea: coder.com/docs labelJun 28, 2024
@ericpaulsenericpaulsen self-assigned thisJun 28, 2024
@ericpaulsenericpaulsen changed the titlefix-sa-docsdocs: fix additional clusters documentationJun 28, 2024
@matifali
Copy link
Member

matifali commentedJul 1, 2024
edited
Loading

Haven't personally verified the updated instructions but changes make sense. LGTM.

Copy link
Collaborator

@stirbystirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll bring the changes into our restructure branch.

Thanks Eric.

matifali reacted with heart emoji
@ericpaulsenericpaulsenenabled auto-merge (squash)July 2, 2024 01:10
@matifalimatifalidisabled auto-mergeJuly 3, 2024 19:23
@matifalimatifali changed the titledocs: fix additional clusters documentationfix-sa-docsJul 3, 2024
@matifalimatifalienabled auto-merge (squash)July 3, 2024 19:23
@matifalimatifali changed the titlefix-sa-docsdocs: fix docs on deploying workspaces in additional namespacesJul 3, 2024
@ericpaulsen
Copy link
MemberAuthor

@matifali do you know why CI is still pending?

@matifalimatifali merged commit90a6025 intomainJul 10, 2024
26 checks passed
@matifalimatifali deleted the fix-sa-docs branchJuly 10, 2024 18:40
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

@stirbystirbystirby approved these changes

@dak1001dak1001Awaiting requested review from dak1001

Assignees

@ericpaulsenericpaulsen

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ericpaulsen@matifali@stirby

[8]ページ先頭

©2009-2025 Movatter.jp