- Notifications
You must be signed in to change notification settings - Fork1k
chore: add envbuilder-dogfood template#13720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's go!
Non-blocking: I wonder if we can extract some common elements of this and the dogfood definitions to avoid copy-pasta?
Yeah I'd like to do that at some point! |
Uh oh!
There was an error while loading.Please reload this page.
I've been dogfooding it for the last few days without any major issues, so putting this under VCS.
This template uses the latest version of
coder/envbuilder
, and makes heavy use of a Docker cache to avoid having to actually execute all of the layers.With this, a newly created workspace is available in approximately 7 minutes from the envbuilder image starting.
Some notes and future work:
/var/run
is a symlink to/run
. Kaniko appears to ignore symbolic links in images, meaning that in the built image there is no/var/run
folder. For now I'm symlinking this in the agent startup script before starting the Docker daemon.docker
group is added to the running system. However, the Coder agent executed by the non-root user doesn't end up in this group. As a workaround, I've made/var/run/docker.sock
world read-writable. The alternative is hacking the agent startup script to includenewgrp
or adding the ability for envbuilder to do the equivalent of anewgrp
invocation.