Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add envbuilder-dogfood template#13720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromcj/envbuilder-dogfood
Jun 28, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJun 28, 2024
edited
Loading

I've been dogfooding it for the last few days without any major issues, so putting this under VCS.

This template uses the latest version ofcoder/envbuilder, and makes heavy use of a Docker cache to avoid having to actually execute all of the layers.
With this, a newly created workspace is available in approximately 7 minutes from the envbuilder image starting.

Some notes and future work:

  1. Some directives in our dogfood Dockerfile currently are not (yet!) supported by our caching (in particular, ENV and ARG commands appear to bust the cache),
  2. Extracting the layers to the filesystem currently takes a significant amount of time. There may be some changes we can do to reduce the time spent here.
  3. If we check the remote cache (e.g. via checking docker logs output) and just run that pre-built cached image, we would have a big speed-up!
  4. On most newer distros,/var/run is a symlink to/run. Kaniko appears to ignore symbolic links in images, meaning that in the built image there is no/var/run folder. For now I'm symlinking this in the agent startup script before starting the Docker daemon.
  5. Because the image gets built in-place, thedocker group is added to the running system. However, the Coder agent executed by the non-root user doesn't end up in this group. As a workaround, I've made/var/run/docker.sock world read-writable. The alternative is hacking the agent startup script to includenewgrp or adding the ability for envbuilder to do the equivalent of anewgrp invocation.

@johnstcnjohnstcn self-assigned thisJun 28, 2024
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's go!

Non-blocking: I wonder if we can extract some common elements of this and the dogfood definitions to avoid copy-pasta?

@johnstcn
Copy link
MemberAuthor

Let's go!

Non-blocking: I wonder if we can extract some common elements of this and the dogfood definitions to avoid copy-pasta?

Yeah I'd like to do that at some point!

@johnstcnjohnstcn merged commit1a87771 intomainJun 28, 2024
@johnstcnjohnstcn deleted the cj/envbuilder-dogfood branchJune 28, 2024 11:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnstcn@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp