NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat: add codegen for audit.AuditableResources entries#1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

coadler merged 3 commits intomainfromcolin/audit-gen

May 10, 2022

Merged

feat: add codegen for audit.AuditableResources entries#1370

coadler merged 3 commits intomainfromcolin/audit-gen

May 10, 2022

Conversation

Copy link

Contributor

coadler commentedMay 10, 2022•
edited
Loading

Closes#1331

Usage:

$ ./coderd/audit/audit_gen.shWorkspaceUserCopythefollowingcodeintothe audit.AuditableResourcestable&database.Workspace{}: {"id":ActionIgnore,// TODO: why"created_at":ActionIgnore,// TODO: why"updated_at":ActionIgnore,// TODO: why"owner_id":ActionIgnore,// TODO: why"organization_id":ActionIgnore,// TODO: why"template_id":ActionIgnore,// TODO: why"deleted":ActionIgnore,// TODO: why"name":ActionIgnore,// TODO: why"autostart_schedule":ActionIgnore,// TODO: why"autostop_schedule":ActionIgnore,// TODO: why},&database.User{}: {"id":ActionIgnore,// TODO: why"email":ActionIgnore,// TODO: why"username":ActionIgnore,// TODO: why"hashed_password":ActionIgnore,// TODO: why"created_at":ActionIgnore,// TODO: why"updated_at":ActionIgnore,// TODO: why"status":ActionIgnore,// TODO: why"rbac_roles":ActionIgnore,// TODO: why},

coadler requested a review fromkylecarbs

May 10, 2022 19:05

coadler self-assigned this

May 10, 2022

Copy link

codecovbot commentedMay 10, 2022•
edited
Loading

Codecov Report

Merging#1370 (3641f3d) intomain (2df92e6) willdecrease coverage by0.25%.
The diff coverage is0.00%.

@@            Coverage Diff             @@##             main    #1370      +/-   ##==========================================- Coverage   67.08%   66.82%   -0.26%==========================================  Files         288      290       +2       Lines       18773    18885     +112       Branches      241      241              ==========================================+ Hits        12593    12620      +27- Misses       4906     4973      +67- Partials     1274     1292      +18

Flag	Coverage Δ
unittest-go-macos-latest	`53.97% <0.00%> (-0.14%)`	⬇️
unittest-go-postgres-	`65.33% <0.00%> (-0.23%)`	⬇️
unittest-go-ubuntu-latest	`56.39% <0.00%> (-0.04%)`	⬇️
unittest-go-windows-2022	`52.40% <0.00%> (-0.05%)`	⬇️
unittest-js	`74.24% <ø> (ø)`

Impacted Files	Coverage Δ
scripts/auditgen/main.go	`0.00% <0.00%> (ø)`
coderd/audit/backends/postgres.go	`38.46% <0.00%> (-30.77%)`	⬇️
codersdk/provisionerdaemons.go	`61.97% <0.00%> (-5.64%)`	⬇️
cli/cliui/agent.go	`77.46% <0.00%> (-4.23%)`	⬇️
peerbroker/listen.go	`84.03% <0.00%> (-3.37%)`	⬇️
coderd/turnconn/turnconn.go	`81.91% <0.00%> (-3.20%)`	⬇️
provisionerd/provisionerd.go	`76.17% <0.00%> (-1.48%)`	⬇️
codersdk/workspaceagents.go	`51.52% <0.00%> (-1.36%)`	⬇️
agent/agent.go	`65.90% <0.00%> (-1.24%)`	⬇️
peer/conn.go	`80.34% <0.00%> (ø)`
... and10 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2df92e6...3641f3d. Read thecomment docs.