Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add DRPC tailnet & cli network telemetry#13687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 19 commits intomainfromethan/cli-telemetry
Jul 3, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJun 27, 2024
edited
Loading

  • Adds aTelemetrySink interface totailnet.Conn to support sending network telemetry events regardless of source.
  • Adds aTelemetrySink implemention fortailnetApiConnector, to be used by the CLI.
  • Adds aTelemetryStore to atailnet.Conn to store and scrub PII from any data used to construct network telemetry events.
  • Sends network telemetry events oncoder speedtest,coder ping, when a workspace agent is reachable, and when an ssh connection session ends.
  • Adds a way to disable network telemetry from the CLI.
  • Telemetry is disabled after attempting to send events to a server that doesn't support receiving them.

A future PR will implement the plumbing necessary to record:

  • Connection age
  • P2P setup time
  • Total connection setup time

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedJun 27, 2024
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson changed the titlechore: add DRPC tailnet & cli implementationchore: add DRPC tailnet & cli network telemetryJun 27, 2024
@ethanndicksonethanndicksonforce-pushed thedean/drpc-network-telemetry-server branch from937bf83 to479df1fCompareJune 28, 2024 07:23
Base automatically changed fromdean/drpc-network-telemetry-server tomainJuly 1, 2024 15:50
@ethanndicksonethanndickson marked this pull request as ready for reviewJuly 2, 2024 13:23
LINK_LOCAL=2;
UNIQUE_LOCAL=3;
LOOPBACK=4;
LOOPBACK=3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As per Slack discussion,UNIQUE_LOCAL was removed in favor of{ v=4, class=PRIVATE } meaning "ipv4 private range" and{ v=6, class=PRIVATE } meaning unique local.

NetcheckIPGlobalV4=17;
NetcheckIPGlobalV6=18;

google.protobuf.BoolValueCaptivePortal=19;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was removed because captive portal checks are disabled in Coder's tailscale fork anyways

@ethanndicksonethanndickson merged commita110d18 intomainJul 3, 2024
@ethanndicksonethanndickson deleted the ethan/cli-telemetry branchJuly 3, 2024 05:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@coadlercoadlerAwaiting requested review from coadler

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp