Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add DRPC tailnet & cli implementation for network telemetry#13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedJun 26, 2024
edited
Loading

  • Adds aTelemetrySink interface totailnet.Conn to support sending network telemetry events regardless of source.
  • Adds aTelemetrySink implemention fortailnetApiConnector, to be used by the CLI.
  • Adds a way to disable network telemetry from the CLI

TODO:

  • Tests

johnstcnand others added2 commitsJune 26, 2024 16:22
- Tests now run on postgres 16 by default when run locally (can be specified with POSTGRES_VERSION)- Adds test-go-pg-16 to test against postgres version 16- Updates Dogfood dockerfile / nix flake to postgres version 16- Updates docker-compose.yaml postgres tag to 16
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedJun 26, 2024
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson changed the titlechore: add DRPC tailnet & cli implementationchore: add DRPC tailnet & cli implementation for network telemetryJun 26, 2024
spikecurtisand others added7 commitsJune 27, 2024 15:38
#13617 bumped the Agent/Tailnet API minor version because it adds telemetry features.  However, we don't actually use the protocol features yet, so it's a bit obnoxious for our CLI client to ask for the newest API version.This is particularly true of the CLI client, since that's distributed separately, so if an end user installs the latest CLI client and their organization hasn't fully upgraded, then it will fail to connect.Since we have a release coming up and the telemetry stuff won't make it, I think we should roll back to version 2.0 until we actually implement the telemetry stuff. That way the newest release (2.13) will work with Coder servers all the way back to 2.9.
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 27, 2024
@ethanndicksonethanndickson deleted the 06-26-chore_add_drpc_tailnet_cli_implementation branchJuly 3, 2024 05:25
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kylecarbskylecarbskylecarbs left review comments

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@ethanndickson@kylecarbs@johnstcn@Emyrk@mtojek@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp