- Notifications
You must be signed in to change notification settings - Fork1k
chore: implement sane default pagination limit for audit logs#13676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // A limit of 0 should be interpreted by the SQL query as "null" or | ||
| // "no limit". Do not make this value anything besides 0. | ||
| Limit:int(parser.PositiveInt32(queryParams,0,"limit")), | ||
| Offset:int(parser.PositiveInt32(queryParams,0,"offset")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added this comment similar to the-1 one before. Should clear it up going forward 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Doesn't this comment directly contradict what happens inauditlogs.sql?
b89f062 to28c3872Compare
Also added a comment to protect the "0" limit going forward.